Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hub election leader controller #2281

Merged

Conversation

tnsimon
Copy link
Contributor

@tnsimon tnsimon commented Jan 29, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add hub leader election controller

Which issue(s) this PR fixes:

Fixes #2259

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?

NONE

other Note

@tnsimon tnsimon requested a review from a team as a code owner January 29, 2025 05:19
@tnsimon tnsimon force-pushed the add-hub-election-leader-controller branch 2 times, most recently from 72bada3 to 42b47ac Compare January 29, 2025 05:26
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 40.09901% with 121 lines in your changes missing coverage. Please review.

Project coverage is 45.85%. Comparing base (d690808) to head (1995b3d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...nager/controller/hubleader/hubleader_controller.go 56.25% 53 Missing and 3 partials ⚠️
...rtmanager/controller/util/node/controller_utils.go 8.82% 31 Missing ⚠️
...md/yurt-manager/app/options/hubleadercontroller.go 0.00% 24 Missing ⚠️
cmd/yurt-manager/app/options/options.go 0.00% 6 Missing ⚠️
pkg/apis/apps/v1beta2/default.go 0.00% 2 Missing ⚠️
pkg/apis/apps/v1alpha1/nodepool_conversion.go 0.00% 1 Missing ⚠️
pkg/apis/apps/v1beta1/nodepool_conversion.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2281      +/-   ##
==========================================
- Coverage   46.39%   45.85%   -0.55%     
==========================================
  Files         416      418       +2     
  Lines       27266    27450     +184     
==========================================
- Hits        12651    12586      -65     
- Misses      13335    13611     +276     
+ Partials     1280     1253      -27     
Flag Coverage Δ
unittests 45.85% <40.09%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnsimon tnsimon force-pushed the add-hub-election-leader-controller branch 2 times, most recently from 4aa2e37 to c936915 Compare February 2, 2025 22:21
@tnsimon tnsimon force-pushed the add-hub-election-leader-controller branch 4 times, most recently from b65b13f to 1c87094 Compare February 3, 2025 00:23
@tnsimon tnsimon force-pushed the add-hub-election-leader-controller branch from fc742ba to 6660dca Compare February 3, 2025 10:27
fix: update configuration param
@tnsimon tnsimon force-pushed the add-hub-election-leader-controller branch from 6660dca to 1995b3d Compare February 3, 2025 10:33
Copy link

sonarqubecloud bot commented Feb 3, 2025

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Feb 3, 2025
@rambohe-ch
Copy link
Member

/LGTM

@rambohe-ch rambohe-ch merged commit 4647c09 into openyurtio:master Feb 3, 2025
13 of 14 checks passed
@tnsimon tnsimon deleted the add-hub-election-leader-controller branch February 3, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]add HubLeaderElection Controller in yurt-manager component.
2 participants