feat: remove YurtAppOverrider #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techworldhello
force-pushed
the
wangjessi/remove-yurtappoverrider
branch
from
375be1d to
1953469
Compare
rambohe-ch
approved these changes
Feb 2, 2025
|
@techworldhello please resolve the conflicted files. maybe you need to rebase the current master branch. |
techworldhello
force-pushed
the
wangjessi/remove-yurtappoverrider
branch
from
1953469 to
ebc411d
Compare
techworldhello
force-pushed
the
wangjessi/remove-yurtappoverrider
branch
from
ebc411d to
9760c31
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2280 +/- ##
==========================================
- Coverage 45.85% 45.68% -0.17%
==========================================
Files 418 408 -10
Lines 27450 27146 -304
==========================================
- Hits 12586 12403 -183
+ Misses 13611 13518 -93
+ Partials 1253 1225 -28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rambohe-ch
approved these changes
Feb 4, 2025
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2263
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?
other Note