Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade k8s.io/xxx to v0.31.5 #2279

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

upgrade k8s.io/xxx(like k8s.io/apiserver) from v0.30.6 to v0.31.5, because the Cacher in v0.31.5 support readiness check, and I will improve readiness probe of Yurthub component in the later pull request.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@rambohe-ch rambohe-ch requested a review from a team as a code owner January 27, 2025 13:10
@rambohe-ch
Copy link
Member Author

@YTGhost @vie-serendipity PTAL

@rambohe-ch rambohe-ch force-pushed the upgrade-k8sio-to-v1.31.5 branch 4 times, most recently from a4c0ad6 to 4f86b7d Compare January 28, 2025 00:04
@vie-serendipity
Copy link
Member

/rerun

@rambohe-ch rambohe-ch force-pushed the upgrade-k8sio-to-v1.31.5 branch from 4f86b7d to c0d1281 Compare January 28, 2025 01:10
@rambohe-ch rambohe-ch force-pushed the upgrade-k8sio-to-v1.31.5 branch from c0d1281 to 9701dd8 Compare January 28, 2025 01:25
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 51.82482% with 66 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@219300f). Learn more about missing BASE report.
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...l/kubernetes/apiserver/options/insecure_serving.go 52.94% 4 Missing and 4 partials ⚠️
...roller/nodelifecycle/node_life_cycle_controller.go 0.00% 8 Missing ⚠️
...nager/controller/internal/controller/controller.go 0.00% 6 Missing ⚠️
...cetopology/endpoints/endpoints_enqueue_handlers.go 0.00% 5 Missing ⚠️
...gy/endpointslice/endpointslice_enqueue_handlers.go 0.00% 5 Missing ⚠️
pkg/yurtmanager/controller/util/tools.go 0.00% 5 Missing ⚠️
pkg/yurthub/multiplexer/storage/fake_storage.go 0.00% 4 Missing ⚠️
...rvice/gateway_internal_service_enqueue_handlers.go 62.50% 3 Missing ⚠️
...service/gateway_public_service_enqueue_handlers.go 66.66% 3 Missing ⚠️
.../yurthub/multiplexer/storage/api_server_storage.go 0.00% 2 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2279   +/-   ##
=========================================
  Coverage          ?   46.10%           
=========================================
  Files             ?      416           
  Lines             ?    27187           
  Branches          ?        0           
=========================================
  Hits              ?    12534           
  Misses            ?    13380           
  Partials          ?     1273           
Flag Coverage Δ
unittests 46.10% <51.82%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vie-serendipity
Copy link
Member

/LGTM @rambohe-ch

Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YTGhost YTGhost merged commit 21473cf into openyurtio:master Jan 28, 2025
14 checks passed
@rambohe-ch
Copy link
Member Author

/backport release-v1.6

Copy link

github-actions bot commented Feb 3, 2025

Backport failed for release-v1.6, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-v1.6
git worktree add -d .worktree/backport-2279-to-release-v1.6 origin/release-v1.6
cd .worktree/backport-2279-to-release-v1.6
git checkout -b backport-2279-to-release-v1.6
ancref=$(git merge-base 219300f8343ba07dfdd95cefaa30a7893c1dde47 9701dd82f0e58cbeeb36993eeece60caf71d02a8)
git cherry-pick -x $ancref..9701dd82f0e58cbeeb36993eeece60caf71d02a8

@rambohe-ch rambohe-ch deleted the upgrade-k8sio-to-v1.31.5 branch February 3, 2025 04:55
@rambohe-ch
Copy link
Member Author

/backport release-v1.6

Copy link

github-actions bot commented Feb 3, 2025

Backport failed for release-v1.6, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-v1.6
git worktree add -d .worktree/backport-2279-to-release-v1.6 origin/release-v1.6
cd .worktree/backport-2279-to-release-v1.6
git checkout -b backport-2279-to-release-v1.6
ancref=$(git merge-base 219300f8343ba07dfdd95cefaa30a7893c1dde47 9701dd82f0e58cbeeb36993eeece60caf71d02a8)
git cherry-pick -x $ancref..9701dd82f0e58cbeeb36993eeece60caf71d02a8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants