Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: masterservice missing clusterIPs field. #2173

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

fungaren
Copy link
Contributor

@fungaren fungaren commented Oct 21, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Set clusterIPs field for masterservice filter.

CoreDNS will read it: https://github.com/coredns/coredns/blob/v1.11.3/plugin/kubernetes/kubernetes.go#L507

About ClusterIPs

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Signed-off-by: fungaren <[email protected]>
Copy link

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.92%. Comparing base (3713163) to head (6dfd167).
Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2173      +/-   ##
==========================================
+ Coverage   56.09%   58.92%   +2.82%     
==========================================
  Files         186      211      +25     
  Lines       18092    19027     +935     
==========================================
+ Hits        10149    11211    +1062     
+ Misses       6910     6731     -179     
- Partials     1033     1085      +52     
Flag Coverage Δ
unittests 58.92% <100.00%> (+2.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Oct 21, 2024
@rambohe-ch
Copy link
Member

/LGTM

@rambohe-ch rambohe-ch merged commit d3c7aad into openyurtio:master Oct 21, 2024
13 checks passed
@fungaren fungaren deleted the fix-masterserivce-cluster-ips branch October 22, 2024 02:27
zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Oct 23, 2024
* fix: masterservice missing clusterIPs field.

Signed-off-by: fungaren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants