Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: build iot system configuration isolation on nodepool(openyurtio#1597) #2135

Merged
merged 16 commits into from
Oct 30, 2024

Conversation

WoShiZhangmingyu
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@LavenderQAQ

@LavenderQAQ LavenderQAQ self-assigned this Aug 25, 2024
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.93%. Comparing base (3713163) to head (7763e7c).
Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2135      +/-   ##
==========================================
+ Coverage   56.09%   58.93%   +2.83%     
==========================================
  Files         186      210      +24     
  Lines       18092    18968     +876     
==========================================
+ Hits        10149    11179    +1030     
+ Misses       6910     6707     -203     
- Partials     1033     1082      +49     
Flag Coverage Δ
unittests 58.93% <ø> (+2.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch
Copy link
Member

/rerun

Copy link

Copy link
Member

@LavenderQAQ LavenderQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@LavenderQAQ LavenderQAQ merged commit 750f834 into openyurtio:master Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants