-
Notifications
You must be signed in to change notification settings - Fork 680
[ROCm] Add missing keepalive timeout for rbe builds in rocm #33414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
alekstheod
wants to merge
1
commit into
openxla:main
from
ROCm:ci_add_missing_keepalive_timeout_for_rbe_builds
Closed
[ROCm] Add missing keepalive timeout for rbe builds in rocm #33414
alekstheod
wants to merge
1
commit into
openxla:main
from
ROCm:ci_add_missing_keepalive_timeout_for_rbe_builds
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckerhe
approved these changes
Nov 4, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
Imported from GitHub PR #33414 📝 Summary of Changes Set keepalive time to prevent connection drop from bazel client during rbe builds 🎯 Justification Set keepalive time to prevent connection drop from bazel client during rbe builds 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix 📊 Benchmark (for Performance Improvements) Not relevant 🧪 Unit Tests: Not relevant 🧪 Execution Tests: Not relevant Copybara import of the project: -- 76a26b3 by Alexandros Theodoridis <[email protected]>: Add missing keepalive timeout for rbe builds in rocm Merging this change closes #33414 FUTURE_COPYBARA_INTEGRATE_REVIEW=#33414 from ROCm:ci_add_missing_keepalive_timeout_for_rbe_builds 76a26b3 PiperOrigin-RevId: 827818530
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 4, 2025
Imported from GitHub PR openxla/xla#33414 📝 Summary of Changes Set keepalive time to prevent connection drop from bazel client during rbe builds 🎯 Justification Set keepalive time to prevent connection drop from bazel client during rbe builds 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix 📊 Benchmark (for Performance Improvements) Not relevant 🧪 Unit Tests: Not relevant 🧪 Execution Tests: Not relevant Copybara import of the project: -- 76a26b318dac967b17a64abfbbbb00ca26980b5a by Alexandros Theodoridis <[email protected]>: Add missing keepalive timeout for rbe builds in rocm Merging this change closes #33414 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#33414 from ROCm:ci_add_missing_keepalive_timeout_for_rbe_builds 76a26b318dac967b17a64abfbbbb00ca26980b5a PiperOrigin-RevId: 827818530
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
Imported from GitHub PR #33414 📝 Summary of Changes Set keepalive time to prevent connection drop from bazel client during rbe builds 🎯 Justification Set keepalive time to prevent connection drop from bazel client during rbe builds 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix 📊 Benchmark (for Performance Improvements) Not relevant 🧪 Unit Tests: Not relevant 🧪 Execution Tests: Not relevant Copybara import of the project: -- 76a26b3 by Alexandros Theodoridis <[email protected]>: Add missing keepalive timeout for rbe builds in rocm Merging this change closes #33414 FUTURE_COPYBARA_INTEGRATE_REVIEW=#33414 from ROCm:ci_add_missing_keepalive_timeout_for_rbe_builds 76a26b3 PiperOrigin-RevId: 827818530
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 4, 2025
Imported from GitHub PR openxla/xla#33414 📝 Summary of Changes Set keepalive time to prevent connection drop from bazel client during rbe builds 🎯 Justification Set keepalive time to prevent connection drop from bazel client during rbe builds 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix 📊 Benchmark (for Performance Improvements) Not relevant 🧪 Unit Tests: Not relevant 🧪 Execution Tests: Not relevant Copybara import of the project: -- 76a26b318dac967b17a64abfbbbb00ca26980b5a by Alexandros Theodoridis <[email protected]>: Add missing keepalive timeout for rbe builds in rocm Merging this change closes #33414 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#33414 from ROCm:ci_add_missing_keepalive_timeout_for_rbe_builds 76a26b318dac967b17a64abfbbbb00ca26980b5a PiperOrigin-RevId: 827818530
beckerhe
approved these changes
Nov 6, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
Imported from GitHub PR #33414 📝 Summary of Changes Set keepalive time to prevent connection drop from bazel client during rbe builds 🎯 Justification Set keepalive time to prevent connection drop from bazel client during rbe builds 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix 📊 Benchmark (for Performance Improvements) Not relevant 🧪 Unit Tests: Not relevant 🧪 Execution Tests: Not relevant Copybara import of the project: -- 76a26b3 by Alexandros Theodoridis <[email protected]>: Add missing keepalive timeout for rbe builds in rocm Merging this change closes #33414 FUTURE_COPYBARA_INTEGRATE_REVIEW=#33414 from ROCm:ci_add_missing_keepalive_timeout_for_rbe_builds 76a26b3 PiperOrigin-RevId: 827818530
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 6, 2025
Imported from GitHub PR openxla/xla#33414 📝 Summary of Changes Set keepalive time to prevent connection drop from bazel client during rbe builds 🎯 Justification Set keepalive time to prevent connection drop from bazel client during rbe builds 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix 📊 Benchmark (for Performance Improvements) Not relevant 🧪 Unit Tests: Not relevant 🧪 Execution Tests: Not relevant Copybara import of the project: -- 76a26b318dac967b17a64abfbbbb00ca26980b5a by Alexandros Theodoridis <[email protected]>: Add missing keepalive timeout for rbe builds in rocm Merging this change closes #33414 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#33414 from ROCm:ci_add_missing_keepalive_timeout_for_rbe_builds 76a26b318dac967b17a64abfbbbb00ca26980b5a PiperOrigin-RevId: 827818530
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
Imported from GitHub PR #33414 📝 Summary of Changes Set keepalive time to prevent connection drop from bazel client during rbe builds 🎯 Justification Set keepalive time to prevent connection drop from bazel client during rbe builds 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix 📊 Benchmark (for Performance Improvements) Not relevant 🧪 Unit Tests: Not relevant 🧪 Execution Tests: Not relevant Copybara import of the project: -- 76a26b3 by Alexandros Theodoridis <[email protected]>: Add missing keepalive timeout for rbe builds in rocm Merging this change closes #33414 FUTURE_COPYBARA_INTEGRATE_REVIEW=#33414 from ROCm:ci_add_missing_keepalive_timeout_for_rbe_builds 76a26b3 PiperOrigin-RevId: 827818530
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 6, 2025
Imported from GitHub PR openxla/xla#33414 📝 Summary of Changes Set keepalive time to prevent connection drop from bazel client during rbe builds 🎯 Justification Set keepalive time to prevent connection drop from bazel client during rbe builds 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix 📊 Benchmark (for Performance Improvements) Not relevant 🧪 Unit Tests: Not relevant 🧪 Execution Tests: Not relevant Copybara import of the project: -- 76a26b318dac967b17a64abfbbbb00ca26980b5a by Alexandros Theodoridis <[email protected]>: Add missing keepalive timeout for rbe builds in rocm Merging this change closes #33414 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#33414 from ROCm:ci_add_missing_keepalive_timeout_for_rbe_builds 76a26b318dac967b17a64abfbbbb00ca26980b5a PiperOrigin-RevId: 827818530
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
Imported from GitHub PR #33414 📝 Summary of Changes Set keepalive time to prevent connection drop from bazel client during rbe builds 🎯 Justification Set keepalive time to prevent connection drop from bazel client during rbe builds 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix 📊 Benchmark (for Performance Improvements) Not relevant 🧪 Unit Tests: Not relevant 🧪 Execution Tests: Not relevant Copybara import of the project: -- 76a26b3 by Alexandros Theodoridis <[email protected]>: Add missing keepalive timeout for rbe builds in rocm Merging this change closes #33414 FUTURE_COPYBARA_INTEGRATE_REVIEW=#33414 from ROCm:ci_add_missing_keepalive_timeout_for_rbe_builds 76a26b3 PiperOrigin-RevId: 827818530
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 6, 2025
Imported from GitHub PR openxla/xla#33414 📝 Summary of Changes Set keepalive time to prevent connection drop from bazel client during rbe builds 🎯 Justification Set keepalive time to prevent connection drop from bazel client during rbe builds 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix 📊 Benchmark (for Performance Improvements) Not relevant 🧪 Unit Tests: Not relevant 🧪 Execution Tests: Not relevant Copybara import of the project: -- 76a26b318dac967b17a64abfbbbb00ca26980b5a by Alexandros Theodoridis <[email protected]>: Add missing keepalive timeout for rbe builds in rocm Merging this change closes #33414 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#33414 from ROCm:ci_add_missing_keepalive_timeout_for_rbe_builds 76a26b318dac967b17a64abfbbbb00ca26980b5a PiperOrigin-RevId: 827818530
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
Imported from GitHub PR #33414 📝 Summary of Changes Set keepalive time to prevent connection drop from bazel client during rbe builds 🎯 Justification Set keepalive time to prevent connection drop from bazel client during rbe builds 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix 📊 Benchmark (for Performance Improvements) Not relevant 🧪 Unit Tests: Not relevant 🧪 Execution Tests: Not relevant Copybara import of the project: -- 76a26b3 by Alexandros Theodoridis <[email protected]>: Add missing keepalive timeout for rbe builds in rocm Merging this change closes #33414 FUTURE_COPYBARA_INTEGRATE_REVIEW=#33414 from ROCm:ci_add_missing_keepalive_timeout_for_rbe_builds 76a26b3 PiperOrigin-RevId: 827818530
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 6, 2025
Imported from GitHub PR openxla/xla#33414 📝 Summary of Changes Set keepalive time to prevent connection drop from bazel client during rbe builds 🎯 Justification Set keepalive time to prevent connection drop from bazel client during rbe builds 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix 📊 Benchmark (for Performance Improvements) Not relevant 🧪 Unit Tests: Not relevant 🧪 Execution Tests: Not relevant Copybara import of the project: -- 76a26b318dac967b17a64abfbbbb00ca26980b5a by Alexandros Theodoridis <[email protected]>: Add missing keepalive timeout for rbe builds in rocm Merging this change closes #33414 Reverts c963ecc FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#33414 from ROCm:ci_add_missing_keepalive_timeout_for_rbe_builds 76a26b318dac967b17a64abfbbbb00ca26980b5a PiperOrigin-RevId: 827818530
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
Imported from GitHub PR #33414 📝 Summary of Changes Set keepalive time to prevent connection drop from bazel client during rbe builds 🎯 Justification Set keepalive time to prevent connection drop from bazel client during rbe builds 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix 📊 Benchmark (for Performance Improvements) Not relevant 🧪 Unit Tests: Not relevant 🧪 Execution Tests: Not relevant Copybara import of the project: -- 76a26b3 by Alexandros Theodoridis <[email protected]>: Add missing keepalive timeout for rbe builds in rocm Merging this change closes #33414 FUTURE_COPYBARA_INTEGRATE_REVIEW=#33414 from ROCm:ci_add_missing_keepalive_timeout_for_rbe_builds 76a26b3 PiperOrigin-RevId: 827818530
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 7, 2025
Imported from GitHub PR openxla/xla#33414 📝 Summary of Changes Set keepalive time to prevent connection drop from bazel client during rbe builds 🎯 Justification Set keepalive time to prevent connection drop from bazel client during rbe builds 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix 📊 Benchmark (for Performance Improvements) Not relevant 🧪 Unit Tests: Not relevant 🧪 Execution Tests: Not relevant Copybara import of the project: -- 76a26b318dac967b17a64abfbbbb00ca26980b5a by Alexandros Theodoridis <[email protected]>: Add missing keepalive timeout for rbe builds in rocm Merging this change closes #33414 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#33414 from ROCm:ci_add_missing_keepalive_timeout_for_rbe_builds 76a26b318dac967b17a64abfbbbb00ca26980b5a PiperOrigin-RevId: 827818530
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 7, 2025
Imported from GitHub PR openxla/xla#33414 📝 Summary of Changes Set keepalive time to prevent connection drop from bazel client during rbe builds 🎯 Justification Set keepalive time to prevent connection drop from bazel client during rbe builds 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix 📊 Benchmark (for Performance Improvements) Not relevant 🧪 Unit Tests: Not relevant 🧪 Execution Tests: Not relevant Copybara import of the project: -- 76a26b318dac967b17a64abfbbbb00ca26980b5a by Alexandros Theodoridis <[email protected]>: Add missing keepalive timeout for rbe builds in rocm Merging this change closes #33414 PiperOrigin-RevId: 829330372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary of Changes
Set keepalive time to prevent connection drop from bazel client during rbe builds
🎯 Justification
Set keepalive time to prevent connection drop from bazel client during rbe builds
🚀 Kind of Contribution
Please remove what does not apply: 🐛 Bug Fix
📊 Benchmark (for Performance Improvements)
Not relevant
🧪 Unit Tests:
Not relevant
🧪 Execution Tests:
Not relevant