Skip to content

Don't link nvrtc-builtins for local CUDA installation (see the discussion in https://github.com/conda-forge/tensorflow-feedstock/pull/414#issuecomment-2629135833) #24247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
copybara-service wants to merge 1 commit into from
+15 −6
Closed

Don't link nvrtc-builtins for local CUDA installation (see the discussion in https://github.com/conda-forge/tensorflow-feedstock/pull/414#issuecomment-2629135833) #24247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions third_party/gpus/cuda/hermetic/cuda_nvrtc.BUILD.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,18 @@ cc_import(
name = "nvrtc_main",
shared_library = "lib/libnvrtc.so.%{libnvrtc_version}",
)

%{multiline_comment}
%{multiline_comment_nvrtc_builtins}
cc_import(
name = "nvrtc_builtins",
shared_library = "lib/libnvrtc-builtins.so.%{libnvrtc-builtins_version}",
)
%{multiline_comment}
%{multiline_comment_nvrtc_builtins}
cc_library(
name = "nvrtc",
%{comment}deps = [
%{comment}":nvrtc_main",
%{comment}":nvrtc_builtins",
%{comment_nvrtc_builtins}":nvrtc_builtins",
%{comment}],
%{comment}linkopts = cuda_rpath_flags("nvidia/cuda_nvrtc/lib"),
visibility = ["//visibility:public"],
Expand Down
14 changes: 11 additions & 3 deletions third_party/gpus/cuda/hermetic/cuda_redist_init_repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,16 @@ def get_lib_name_to_version_dict(repository_ctx):
return lib_name_to_version_dict

def create_dummy_build_file(repository_ctx, use_comment_symbols = True):
multiline_comment_symbol = "'''" if use_comment_symbols else ""
comment_symbol = "#" if use_comment_symbols else ""
repository_ctx.template(
"BUILD",
repository_ctx.attr.build_templates[0],
{
"%{multiline_comment}": "'''" if use_comment_symbols else "",
"%{comment}": "#" if use_comment_symbols else "",
"%{multiline_comment}": multiline_comment_symbol,
"%{multiline_comment_nvrtc_builtins}": multiline_comment_symbol,
"%{comment}": comment_symbol,
"%{comment_nvrtc_builtins}": comment_symbol,
},
)

Expand Down Expand Up @@ -169,7 +173,8 @@ def get_major_library_version(repository_ctx, lib_name_to_version_dict):
def create_build_file(
repository_ctx,
lib_name_to_version_dict,
major_lib_version):
major_lib_version,
is_cuda_local = False):
# buildifier: disable=function-docstring-args
"""Creates a BUILD file for the repository."""
if len(major_lib_version) == 0:
Expand All @@ -191,6 +196,8 @@ def create_build_file(
lib_name_to_version_dict | {
"%{multiline_comment}": "",
"%{comment}": "",
"%{comment_nvrtc_builtins}": "#" if is_cuda_local else "",
"%{multiline_comment_nvrtc_builtins}": "'''" if is_cuda_local else "",
},
)

Expand Down Expand Up @@ -249,6 +256,7 @@ def use_local_path(repository_ctx, local_path, dirs):
repository_ctx,
lib_name_to_version_dict,
major_version,
is_cuda_local = True,
)
_create_libcuda_symlinks(
repository_ctx,
Expand Down