Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dup third_party/py/ml_dtypes as it is not used. #15831

Closed
wants to merge 1 commit into from

Conversation

apivovarov
Copy link
Contributor

Remove duplicate location of ml_dtypes - third_party/py/ml_dtypes as it is not used.

The actively used ml_dtypes is located in third_party/tsl/third_party/py/ml_dtypes

@NaiyerRizz NaiyerRizz added the kokoro:force-run Forces CI to rerun label Aug 8, 2024
@NaiyerRizz NaiyerRizz self-assigned this Aug 8, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Forces CI to rerun label Aug 8, 2024
@dimitar-asenov dimitar-asenov requested review from ddunl and removed request for dimitar-asenov and NaiyerRizz August 8, 2024 07:58
@apivovarov
Copy link
Contributor Author

Hi David, I think this PR may have been missed. Could you take a look? @ddunl

@ddunl
Copy link
Member

ddunl commented Aug 12, 2024

Ah it was, sorry about that. In principle this PR is correct, but the change do it internally is a bit awkward as this is generated in some sense by our Copybara config file. It will be fixed once TSL has been completely moved inside XLA which I'm currently working on. If there's a specific reason though why it would be helpful to not keep the duplicate around I can import this and then patch with the Copybara change. Let me know what you think!

@apivovarov
Copy link
Contributor Author

I'm working on adding support for the float8_e4m3 type in ml_dtypes PR-161 and XLA. While doing so, I noticed that ML_DTYPES_COMMIT is defined in two places within XLA, but only one of them is actually used. This isn't a blocker for me; I just decided to clean it up.

Since the duplication will eventually be addressed, I think this PR can be closed.

@apivovarov apivovarov closed this Aug 13, 2024
@apivovarov apivovarov deleted the rm_ml_dtypes branch August 13, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants