Skip to content

Commit

Permalink
Move a TODO to an existing GH issue:
Browse files Browse the repository at this point in the history
  • Loading branch information
peplin committed Sep 8, 2014
1 parent de715f8 commit 87d2cd2
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions openxc/src/com/openxc/messages/Command.java
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,6 @@ public Command(CommandType command) {
this(command, null);
}

// TODO this seems really odd, that we're combined these two things. it made
// more sense when I implemented it in Python. I can't remember...why we are
// wrapping the DiagRequest in a command? I think it was to make parsing
// easier on the other end, so you didn't have to try and infer what the
// incoming datatype was. should we require all input data to be wrapped in
// a command? that would make more sense but would increase a litle overhead
// for JSON writes. Let's get this working for now and then change the
// message format so that we don't use implicit types in JSON anymore - if
// you need maximum performance, use the binary encoding.
public Command(DiagnosticRequest request, String action) {
this(CommandType.DIAGNOSTIC_REQUEST, action);
mDiagnosticRequest = request;
Expand Down

0 comments on commit 87d2cd2

Please sign in to comment.