Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-spoofer: add package #4287

Closed
wants to merge 1 commit into from

Conversation

kenkeys
Copy link

@kenkeys kenkeys commented Jul 24, 2020

Signed-off-by: Ken Keys [email protected]

And just to be clear, I do have a copyright assignment on file with UC.

@aparcar
Copy link
Member

aparcar commented Jul 29, 2020

Hi, thanks for your contribution! Please see #3378. We try to get rid of Lua dependencies, would you mind rewriting the views in JavaScript? The framework offers a often 1to1 translation from Lua to JavaScript.

@aparcar aparcar added the New package New package for the repository label Jul 29, 2020
@feckert
Copy link
Member

feckert commented Jul 30, 2020

Also please switch from <space> to <tab> alignment

@kenkeys
Copy link
Author

kenkeys commented Jul 30, 2020

Hi, thanks for your contribution! Please see #3378. We try to get rid of Lua dependencies, would you mind rewriting the views in JavaScript? The framework offers a often 1to1 translation from Lua to JavaScript.

Do you mean just luasrc/view, or all of luasrc? Whichever it is, where is the documentation for doing this?

@aparcar
Copy link
Member

aparcar commented Jul 30, 2020

The JS documentation is https://openwrt.github.io/luci/jsapi/index.html
If you look trough previous pull requests multiple convert Lua server side rendering to JS client side rendering.

@kenkeys
Copy link
Author

kenkeys commented Jul 30, 2020

You didn't answer: Do you mean just luasrc/view, or all of luasrc?

@aparcar
Copy link
Member

aparcar commented Jul 30, 2020

Ideally all so you loose the luci-compat dependency.

@systemcrash
Copy link
Contributor

Hi @kenkeys - are you interested to rewrite this in JS?

@systemcrash
Copy link
Contributor

If so, please submit a new PR

@systemcrash systemcrash closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New package New package for the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants