[feature] Add websocket endpoint for all location updates #191 #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dee077
changed the title
dee077
moved this to In progress
in [GSoC25] General Map: Indoor, Mobile, Linkable URLs
pandafy
requested changes
Dec 4, 2025
django_loci/channels/base.py
Outdated
| from django.core.exceptions import ValidationError | ||
|
|
||
| location_broadcast_path = "ws/loci/location/<uuid:pk>/" | ||
| all_location_broadcast_path = "ws/loci/location/all/" |
Member
There was a problem hiding this comment.
Instead of all, can we use common_location_broadcast_path?
We can also follow the REST naming convention, but we will need to do that in backward compatible fashion. We can create a separate issue for this.
Member
Author
There was a problem hiding this comment.
Updated!
location_broadcast_path = "ws/loci/locations/uuid:pk/"
common_location_broadcast_path = "ws/loci/locations/"
also made location_broadcast_path consistent by making location to locations
Let me know if it is not required!
Implemented a new websocket endpoint 'location/all/' to handle updates for all locations simultaneously. Fixes #191
dee077
force-pushed
the
feature/191-new-ws-endpoint-for-all-location
branch
from
9e8b063 to
d58772f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a new websocket endpoint 'location/all/' to handle updates for all locations simultaneously.
Fixes #191
Checklist
Reference to Existing Issue
Closes #191
Description of Changes
ws/loci/location/all/Screen Recording
Screencast.from.2025-11-07.17-47-18.webm