[qa] Switched to prettier for CSS/JS formatting #33
Conversation
|
@nemesifier |
|
Hey @nemesifier ./setup.py:24:89: E501 line too long (90 > 88 characters)
ERROR: Flake8 check failed!I have used multiline string to fix this |
setup.py
Outdated
| '''openwisp-utils[qa] | ||
| @ https://github.com/openwisp/openwisp-utils/tarball/1.2''', |
There was a problem hiding this comment.
| '''openwisp-utils[qa] | |
| @ https://github.com/openwisp/openwisp-utils/tarball/1.2''', | |
| ( | |
| 'openwisp-utils[qa]' | |
| ' @ https://github.com/openwisp/openwisp-utils/tarball/1.2' | |
| ), |
There was a problem hiding this comment.
Can we configure prettier to exclude files in /lib/ directory?
.prettierignore
Outdated
| @@ -0,0 +1 @@ | |||
| flat_json_widget/static/flat-json-widget/js/lib/*.js | |||
There was a problem hiding this comment.
This file does not have a blank line at the end.
Configure your code editor to always add a blank line.
There was a problem hiding this comment.
Hi @youhaveme9
Kindly link the issue for which this PR is created, if there is no issue, create one.
.prettierignore
Outdated
| @@ -0,0 +1 @@ | |||
| flat_json_widget/static/flat-json-widget/js/lib/*.js | |||
There was a problem hiding this comment.
nit:No new line at the end
There was a problem hiding this comment.
@youhaveme9 link the prettier issue from openwisp-utils in the PR description please.
Related to: openwisp/openwisp-utils#367.