Update to Reaction context #1315
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that includes a bunch of new features that I had in the wings but was waiting for some feedback from the folks I made the changes for (which never came). In light of openwebwork/mathquill#41, I thought I'd fix that problem, and include these other changes as well.
The changes here are to:
See the changes to the comments (in particular the new large section on molecular form). There are a bunch of new flags to control how the checking is performed.
The new section in the
Close()
method of thecontext::Reaction
package is the part that fixes the parentheses around charges.Some methods that are common to multiple objects have been moved into a new
context::Reaction::common
package, and there is new data stored about the elements in a compound that is used to manage the molecular form. Most of the rest is new methods used for computing the molecular forms.