Add the fp16 support for IsNaN input #32926
Conversation
sgbihu
force-pushed
the
fix_nan_input
branch
from
c97060a to
348675c
Compare
github-actions
bot
added
the
category: IE Tests
sgbihu
requested review from
olpipi and
sbalandi
and removed request for
olpipi
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a heap-buffer-overflow exception that occurred when the IsNaN operation receives fp16 (float16) input. The fix involves relocating the generate function for IsNaN and adding proper type handling to use the is_inf::fill_tensor template function with the correct type parameter based on the input element type.
Key Changes
- Moved the
generatefunction forov::op::v10::IsNaNto after theis_infnamespace definition - Added conditional logic to handle fp16 inputs by calling
is_inf::fill_tensor<ov::float16>for fp16 types andis_inf::fill_tensor<float>for other types
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sgbihu
force-pushed
the
fix_nan_input
branch
from
348675c to
16a7be9
Compare
Fixed the heap-buffer-overflow exception
sgbihu
force-pushed
the
fix_nan_input
branch
from
16a7be9 to
ed57f63
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| namespace is_inf { | ||
| namespace is_cmp { |
There was a problem hiding this comment.
It looks like not required change
|
@olpipi review, please. |
sgbihu
force-pushed
the
fix_nan_input
branch
from
ed57f63 to
2bdee7a
Compare
4 participants
Details:
Tickets: