Skip to content

Conversation

Sujanian1304
Copy link
Contributor

this solves issue #29721

Details:

-added support for prim::data

Tickets:

@Sujanian1304 Sujanian1304 requested a review from a team as a code owner September 20, 2025 05:38
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Sep 20, 2025
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Sep 20, 2025
@Sujanian1304
Copy link
Contributor Author

Sujanian1304 commented Sep 20, 2025

hello @mvafin @PiotrKrzem @p-wysocki @mlukasze @mitruska ,I have submitted this pull request to Add support for prim::data operation.please let me know your feedback on my PR , Thanks.

Best Regards
Piyush

@mlukasze mlukasze linked an issue Sep 22, 2025 that may be closed by this pull request
@mlukasze
Copy link
Contributor

build_jenkins

{"prim::TupleIndex", op::translate_tuple_index},
// prim::TupleUnpack - Supported in limited set of patterns
{"prim::type", op::skip_node}, // Used with prim::device, pass PtFrameworkNode.
{"prim::data", op::translate_data},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be op::skip_node. Doesn't think you need any special handling for complex types in this case.

tensor = torch.from_numpy(data).to(self.dtype)
return (tensor.numpy(),)

@pytest.mark.parametrize("dtype", [torch.float32, torch.float64, torch.int32, torch.int64])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test case for complex numbers too

@Sujanian1304
Copy link
Contributor Author

hey @mvafin ,thanks for the feedback.I have addressed all of your suggestions and added test cases for complex-types,changed to op::skip_node.Please let me know if any other changes are needed.

@mlukasze
Copy link
Contributor

build_jenkins

@mlukasze mlukasze requested a review from mvafin September 23, 2025 05:11
@Sujanian1304
Copy link
Contributor Author

Hi @mlukasze @mvafin @PiotrKrzem @p-wysocki , just following up to see if you’ve had a chance to look at this PR. Let me know if any changes are needed or if there are questions I can clarify. Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: PyTorch FE OpenVINO PyTorch Frontend ExternalPR External contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Support prim::data
4 participants