Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Use src buffer size for copy_to() call when called for two cldnn::memory objects #29534

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[GPU] Use src buffer size for copy_to() call when called for two cldnn::memory objects #29534

wants to merge 3 commits into from
+49 −1

Conversation

sshlyapn
Copy link
Contributor

Details:

  • Use src buffer size for copy_to() call when called for two cldnn::memory objects

Tickets:

@sshlyapn sshlyapn added the category: GPU OpenVINO GPU plugin label Mar 18, 2025
@sshlyapn sshlyapn added this to the 2025.2 milestone Mar 18, 2025
@sshlyapn sshlyapn requested review from a team as code owners March 18, 2025 09:02
vladimir-paramuzov
vladimir-paramuzov reviewed Mar 18, 2025
View reviewed changes
src/plugins/intel_gpu/src/runtime/ocl/ocl_memory.cpp Outdated
@@ -17,6 +17,23 @@
#include <oneapi/dnnl/dnnl_ocl.hpp>
#endif

#define BOUNDARIES_CHECK(copy_type, src_size, src_offset, dst_size, dst_offset, copy_size) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd suggest using a function instead of macro

vladimir-paramuzov
vladimir-paramuzov approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@vladimir-paramuzov vladimir-paramuzov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM

@sshlyapn sshlyapn mentioned this pull request Mar 18, 2025
Merged
@p-durandin p-durandin enabled auto-merge March 19, 2025 05:56
github-merge-queue bot pushed a commit that referenced this pull request Mar 19, 2025
@sshlyapn
[GPU] Use src buffer size for copy_to() call when called for two cldn…
bb8f4ec 
…n::memory objects (#29542)

### Details:
- Use src buffer size for copy_to() call when called for two
cldnn::memory objects
- Simplified backport of
#29534

### Tickets:
 - [CVS-164403](https://jira.devtools.intel.com/browse/CVS-164403)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimir-paramuzov vladimir-paramuzov vladimir-paramuzov approved these changes

@p-durandin p-durandin p-durandin approved these changes

Assignees
No one assigned
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Milestone
2025.2
Development

Successfully merging this pull request may close these issues.
3 participants
@sshlyapn @vladimir-paramuzov @p-durandin