Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISTFT][Op][CPU][Ref] Audio results noise reduction #29533

Merged

Conversation

mitruska
Copy link
Contributor

@mitruska mitruska commented Mar 18, 2025

PR to the releases/2025/1

Details:

  • Audio results noise reduction (Update of reference and CPU implementation of ISTFT)
    • Multiplication of irdft results before add & Normalization update
  • Verified on the model from the ticket

*Further work: Update tests to be able detect smaller differences

Tickets:

  • 160711 (For related model)

PR to the master:

@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin labels Mar 18, 2025
@mitruska mitruska added this to the 2025.1 milestone Mar 18, 2025
@mitruska mitruska self-assigned this Mar 18, 2025
@mitruska mitruska marked this pull request as ready for review March 18, 2025 09:17
@mitruska mitruska requested review from a team as code owners March 18, 2025 09:17
@mitruska
Copy link
Contributor Author

Failing check is caused by unrelated issue (already reported, ticket: 164466).

@akladiev
Copy link
Collaborator

Failing check is caused by unrelated issue (already reported, ticket: 164466).

JFYI: It won't block your PR from being added to queue & merged, as it's set as non-required now

github-merge-queue bot pushed a commit that referenced this pull request Mar 18, 2025
PR to the master branch

### Details:
- Audio results noise reduction (Update of reference and CPU
implementation of ISTFT)
     - Multiplication of irdft results before add & Normalization update
  - Verified on the model from the ticket
 -----------------
 *Further work: Update tests to be able detect smaller differences
 
### Tickets:
 - 160711 (For related model)
 
PR to the 2025.1:
- #29533
@mitruska mitruska added this pull request to the merge queue Mar 18, 2025
Merged via the queue into openvinotoolkit:releases/2025/1 with commit 88032d3 Mar 18, 2025
186 of 188 checks passed
@mitruska mitruska deleted the mitruska/fix_istft_noise branch March 18, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants