[Torch FX] Remove Xfail for FX Models #3368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexander Dokuchaev <[email protected]>
github-actions
bot
added
NNCF PT
github-actions
bot
removed
NNCF PT
daniil-lyakhov
approved these changes
Mar 25, 2025
MaximProshin
requested changes
Mar 25, 2025
|
Job on the latest commit: job/NNCF/job/weekly/job/openvino-nightly/job/post_training_quantization/92/ - passed |
MaximProshin
requested changes
Mar 26, 2025
There was a problem hiding this comment.
After offline discussions it turned out that we can't merge it until 2025.1 is released, so we have to wait.
@anzr299 @daniil-lyakhov , please collect results after the release to make it works on the develop and then we will merge it.
|
@anzr299, please squash your comment, rebase the pr and run the conformance test with your changes |
|
I think #3321 also achieves the same result. So maybe we can review over there? |
|
@anzr299 , feel free to close this PR |
|
Sure, okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove Xfail for FX models.
Reason for changes
These changes are in order to revert xFails placed for FX models due to issue with openvino model conversion of torch exported model ref. 162009.
Related tickets
162009
Tests