Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸš€ Add VAD dataset #2603

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

abc-125
Copy link
Contributor

@abc-125 abc-125 commented Mar 14, 2025

πŸ“ Description

Added one-class (unsupervised) version of VAD dataset, which contains one category of complex industrial objects.

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@abc-125 abc-125 changed the title Feature/data/add vad πŸš€ Add VAD dataset Mar 14, 2025
Example:
Create VAD datamodule with default settings::

>>> datamodule = VAD()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have built-in validation set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this dataset follows the classic AD dataset setup with no validation set :)

If somebody needs a validation set to optimize parameters, it should be possible to download a full (supervised) version with both good and bad images in the training set and take it from there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we support supervised anomaly detection models, we could add VAD's full supervised version. In this case, how much change/modification do you think we need to add to this implementation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, it would depend on the implementation, but it should not be too complicated.

I would imagine having three types of supervised AD datasets; one is adding a set of bad images for training (VAD), another is having several splits over the entire dataset which contains good and bad images into training and test (KolektorSDD), and last one is taking N images from bad images from the test set randomly for existing not supervised datasets (supervised version of MVTecAD, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants