GTEST: Refactored protocol selection mock #10369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakhmets
reviewed
Dec 31, 2024
| UCS_MOCK_ORIG_FUNC(m_self->m_mock, &m_self->m_tl->query_devices, md, | ||
| tl_devices_p, num_tl_devices_p); | ||
| if (*num_tl_devices_p == 0) { | ||
| return UCS_OK; |
There was a problem hiding this comment.
Suggested change
| return UCS_OK; | |
| return UCS_ERR_NO_DEVICE; |
There was a problem hiding this comment.
It's a normal situation when query returns 0 devices, and original function returns UCS_OK in this case.
Comment on lines
94
to
95
| tmp = (uct_tl_device_resource_t *)ucs_malloc( | ||
| sizeof(*tmp) * size,"mock_tl_devices"); |
There was a problem hiding this comment.
Suggested change
| tmp = (uct_tl_device_resource_t *)ucs_malloc( | |
| sizeof(*tmp) * size,"mock_tl_devices"); | |
| auto tmp = (uct_tl_device_resource_t *)ucs_malloc( | |
| sizeof(*tmp) * size, "mock_tl_devices"); |
There was a problem hiding this comment.
Ok, applied with some other changes to make compiler happy
| sizeof(*tmp) * size,"mock_tl_devices"); | ||
| ucs_sys_device_t sys_dev = 1; | ||
| unsigned i = 0; | ||
| for (auto & it : m_self->m_iface_attrs_funcs) { |
There was a problem hiding this comment.
Suggested change
| for (auto & it : m_self->m_iface_attrs_funcs) { | |
| for (const auto &it : m_self->m_iface_attrs_funcs) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR contains enhancements of the original protocol selection mock (#9989):
rc_mlx5/mock_0:1 50% on path0 and 50% on path1)Finally all those changes are needed to reproduce real protocol selection issues (like https://redmine.mellanox.com/issues/4177809, https://redmine.mellanox.com/issues/4134043)