UCP/WIREUP: Support EP reconfiguration for non wired-up scenarios #10337
+249
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roiedanino
reviewed
Dec 10, 2024
src/ucp/core/ucp_ep.c
Outdated
Comment on lines
1845
to
1849
| for (lane = 0; lane < ucp_ep_num_lanes(ep); lane++) { | ||
| if (ucp_wireup_ep_test(ucp_ep_get_lane(ep, lane))) { | ||
| return lane; | ||
| } | ||
| } |
There was a problem hiding this comment.
Wouldn't it be better to save wireup_ep in worker, and then access it in O(1)?
roiedanino
reviewed
Dec 10, 2024
| continue; | ||
| } | ||
|
|
||
| if (dev_count++ >= max_num_devs) { |
There was a problem hiding this comment.
why do you need dev_count? lane has the same values here
shasson5
force-pushed
the
reconf4
branch
2 times, most recently
from
6194b9a to
05a18e8
Compare
shasson5
force-pushed
the
reconf4
branch
2 times, most recently
from
7261edc to
3eb6604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
UCP/WIREUP: Support EP reconfiguration for non wired-up scenarios
Why?
Another step in EP reconfiguration support