Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCP/WIREUP: Consider EP priority in iface score calculation #10321

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

UCP/WIREUP: Consider EP priority in iface score calculation #10321

wants to merge 8 commits into from
+73 −31

Conversation

shasson5
Copy link
Contributor

@shasson5 shasson5 commented Nov 25, 2024 •
edited
Loading

What?

Consider EP priority in iface score calculation.

Why?

Prioritize RC over DC for promoted EPs in selection process.

How?

  1. Add is_prioritized flag to score funcion callback.
  2. Set est_num_eps to small number if EP is prioritized (in order to get better latency and thus select this EP).

@shasson5 shasson5 requested review from yosefe and gleon99 November 25, 2024 12:21
@shasson5
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@shasson5 shasson5 changed the title UCP/WIREUP: Consider EP promoted flag in iface score calculation UCP/WIREUP: Consider EP promoted flag for iface score calculation Nov 28, 2024
evgeny-leksikov
evgeny-leksikov reviewed Jan 16, 2025
View reviewed changes
src/ucp/core/ucp_context.h Outdated Show resolved Hide resolved
src/ucp/core/ucp_ep.h Outdated Show resolved Hide resolved
src/ucp/wireup/select.c Outdated Show resolved Hide resolved
evgeny-leksikov
evgeny-leksikov previously approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@evgeny-leksikov evgeny-leksikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the minor comment - mybe rename is_prioritized flag to smth like prioritized_ep to avoid wrong association with iface priority and please update PR title/description and the commit message on squash because current one is not relevant.

@shasson5 shasson5 changed the title UCP/WIREUP: Consider EP promoted flag for iface score calculation UCP/WIREUP: Consider EP priority in iface score calculation Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeny-leksikov evgeny-leksikov evgeny-leksikov approved these changes

@yosefe yosefe Awaiting requested review from yosefe

@gleon99 gleon99 Awaiting requested review from gleon99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shasson5 @evgeny-leksikov