Apply review feedback

opentripplanner · Jan 3, 2025 · 1518e38 · 1518e38
1 parent 5cc6812
commit 1518e38
Showing 1 changed file with 21 additions and 16 deletions.
diff --git a/pom.xml b/pom.xml
@@ -59,21 +59,23 @@
 
     <properties>
         <otp.serialization.version.id>176</otp.serialization.version.id>
+
         <!-- Lib versions - keep list sorted on property name -->
         <geotools.version>32.1</geotools.version>
         <google.dagger.version>2.53</google.dagger.version>
         <jackson.version>2.18.2</jackson.version>
+        <jaxb-runtime.version>4.0.5</jaxb-runtime.version>
         <jersey.version>3.1.9</jersey.version>
         <junit.version>5.11.4</junit.version>
-        <micrometer.version>1.14.1</micrometer.version>
-        <netcdf4.version>5.6.0</netcdf4.version>
         <logback.version>1.5.12</logback.version>
         <lucene.version>9.12.0</lucene.version>
-        <slf4j.version>2.0.16</slf4j.version>
+        <micrometer.version>1.14.1</micrometer.version>
         <netex-java-model.version>2.0.15</netex-java-model.version>
-        <siri-java-model.version>1.27</siri-java-model.version>
-        <jaxb-runtime.version>4.0.5</jaxb-runtime.version>
+        <netcdf4.version>5.6.0</netcdf4.version>
         <protobuf.version>4.28.3</protobuf.version>
+        <siri-java-model.version>1.27</siri-java-model.version>
+        <slf4j.version>2.0.16</slf4j.version>
+
         <!-- Other properties -->
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <GITHUB_REPOSITORY>opentripplanner/OpenTripPlanner</GITHUB_REPOSITORY>
@@ -390,14 +392,26 @@
     <dependencyManagement>
         <dependencies>
             <dependency>
-                <!-- This make sure all google libraries are using compatible versions. -->
+                <!-- This makes sure all google libraries are using compatible versions. -->
                 <groupId>com.google.cloud</groupId>
                 <artifactId>libraries-bom</artifactId>
                 <version>26.51.0</version>
                 <type>pom</type>
                 <scope>import</scope>
             </dependency>
 
+            <dependency>
+                <groupId>com.google.protobuf</groupId>
+                <artifactId>protobuf-java</artifactId>
+                <version>${protobuf.version}</version>
+            </dependency>
+
+            <dependency>
+                <groupId>com.google.guava</groupId>
+                <artifactId>guava</artifactId>
+                <version>33.3.1-jre</version>
+            </dependency>
+
             <!-- Logging API -->
             <dependency>
                 <groupId>org.slf4j</groupId>
@@ -420,11 +434,6 @@
                 <artifactId>trove4j</artifactId>
                 <version>3.0.3</version>
             </dependency>
-            <dependency>
-                <groupId>com.google.guava</groupId>
-                <artifactId>guava</artifactId>
-                <version>33.3.1-jre</version>
-            </dependency>
 
             <!-- GEOTOOLS AND JTS TOPOLOGY: geometry, rasters and projections. -->
             <!-- GEOTOOLS includes JTS as a transitive dependency. -->
@@ -486,11 +495,7 @@
                 <artifactId>java-snapshot-testing-junit5</artifactId>
                 <version>2.3.0</version>
             </dependency>
-            <dependency>
-                <groupId>com.google.protobuf</groupId>
-                <artifactId>protobuf-java</artifactId>
-                <version>${protobuf.version}</version>
-            </dependency>
+
         </dependencies>
     </dependencyManagement>