#15: Update to use aws sdk v3 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callmekatootie
commented
Apr 11, 2024
| } | ||
|
|
||
| params = await ssm.getParametersByPath(config).promise() | ||
| nextToken = params.NextToken | ||
| config.NextToken = nextToken |
There was a problem hiding this comment.
I am not sure why here we invoked getParametersByPath() once again - we could have simply used the token from the previous call. Pointing it out just in case it gets missed in the review and if you think there's a valid reason for it.
I have removed the duplicate call for now. Tests seem to pass
callmekatootie
commented
Apr 11, 2024
| const name = param.Name.split('/') | ||
| const svc = name[3] | ||
| svcs[svc] = svcs[svc] ? svcs[svc] + 1 : 1 | ||
| } | ||
|
|
||
| params = await ssm.getParametersByPath(config).promise() | ||
| nextToken = params.NextToken | ||
| config.NextToken = nextToken |
There was a problem hiding this comment.
Same issue as the previous comment here as well
Open
lbelling
changed the title
danieljse
approved these changes
Apr 11, 2024
| } | ||
|
|
||
| params = await ssm.getParametersByPath(config).promise() | ||
| nextToken = params.NextToken | ||
| config.NextToken = nextToken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15
Also contains