fix: imbuement check for empty slots #3370
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the handling of imbuement slots by checking if a slot is empty before attempting to retrieve imbuement information. Previously, the function
getImbuementInfo
would return an invalid imbuement even when the slot was empty. Now, it ensures that only valid imbuements are considered.Behaviour
Actual
Expected
getImbuementInfo
now checks if the slot has an associated custom attribute.false
immediately, avoiding unnecessary operations.Fixes #issuenumber
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Tests performed:
false
ingetImbuementInfo
.Checklist