Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exori gran con damage bonus #3321

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mdbeng
Copy link
Contributor

@mdbeng mdbeng commented Feb 4, 2025

this fixes the excessive damage output from skill wheel such as enhanced ethereal spear, the damage output still too high in comparison to real tibia. ( the high output is on all the spells boosted by skill wheel )

This fixes Issue #3313
Aided by " @lBaah " Much appreciated.

Description

Before this PR using boosted spells from skill wheel will result in high damage output 9.000 +
This will prevent this from happening but the damage output still a little too high for realistic purposes.

Behaviour

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes #issuenumber

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Clean Base
  • Different Vocations / Skills / Levels

Test Configuration:

  • Server Version: 13.4
  • Client: 13.4
  • Operating System: Linux / Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

this fixes the excessive damage output from skill wheel such as enhanced ethereal speak, the damage output still too high in comparison to real tibia.
This was linked to issues Feb 4, 2025
This was unlinked from issues Feb 4, 2025
@murilo09 murilo09 changed the title Perf: skill wheel bonus fix: skill wheel bonus Feb 4, 2025
src/game/game.cpp Outdated Show resolved Hide resolved
@murilo09 murilo09 linked an issue Feb 4, 2025 that may be closed by this pull request
5 tasks
@murilo09 murilo09 changed the title fix: skill wheel bonus fix: exori gran con damage bonus Feb 4, 2025
Copy link

sonarqubecloud bot commented Feb 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exori Gran Con skill wheel bugged
2 participants