feat: add support to load items using dat file from spr #3159
+418
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilo09
changed the title
|
|
could you check the failed builds? |
murilo09
requested changes
Dec 31, 2024
Comment on lines
+592
to
+593
| -- NOTE: load items using dat file from old spr and dat cip files, or use default protobuff file if this false | ||
| loadItemsFromSprDat = true |
There was a problem hiding this comment.
Suggested change
| -- NOTE: load items using dat file from old spr and dat cip files, or use default protobuff file if this false | |
| loadItemsFromSprDat = true | |
| -- NOTE: load items using dat file from old spr and dat cip files, or use default protobuf file if false | |
| loadItemsFromSprDat = false |
murilo09
requested changes
Dec 31, 2024
| break; | ||
|
|
||
| case DatAttrMarket: { | ||
| auto category = props.read<uint16_t>(); |
|
|
||
| case DatAttrMarket: { | ||
| auto category = props.read<uint16_t>(); | ||
| auto tradeAsObjectId = props.read<uint16_t>(); |
| case DatAttrMarket: { | ||
| auto category = props.read<uint16_t>(); | ||
| auto tradeAsObjectId = props.read<uint16_t>(); | ||
| auto showAsObjectId = props.read<uint16_t>(); |
| auto tradeAsObjectId = props.read<uint16_t>(); | ||
| auto showAsObjectId = props.read<uint16_t>(); | ||
| auto name = props.readString(); | ||
| auto vocation = props.read<uint16_t>(); |
| auto showAsObjectId = props.read<uint16_t>(); | ||
| auto name = props.readString(); | ||
| auto vocation = props.read<uint16_t>(); | ||
| auto minimumLevel = props.read<uint16_t>(); |
|
This PR is stale because it has been open 45 days with no activity. |
|
You need to change here: Line 348 in 3046566 For send the "Tibia.dat" message instead of "appearances.dat" depending from config.lua key You can replace "appearances.dat" with "items.dat" everywhere in the code. This will simplify things since only one method will be used, making it unnecessary to have both names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PT-BR:
Foi adicionado o suporte para carregar os itens a partir de um .Dat de uma Spr e Dat.
Com isso podemos continuar utilizando editores de spr e dat como o object builder para agilizar o desenvolvimento de servidores derivados.
O assets editor quebra um galho, mas contem diversos problemas, ao tentar utilizar o mesmo algumas vezes para criar servidores derivados no canary, acabei desistindo por conta da grande quantidade de problemas que ele apresenta ao tentar trabalhar com ele por algumas horas aberto modificando centas de itens por hora.
Com esse suporte o desenvolvimento de servidores derivados como Naruto, Pokemon, Dragon Ball e entre outros, se torna mais simples , e mais similar ao que toda a comunidade de derivados já está acostumado.
Quebrando uma barreia enorme entre a comunidade de derivados que se mantem na tfs por conta das facilidades dos editores.
Pelo menos até conseguirmos um editor para assets tão bom quanto o ObjectBuilder e a finalizacão do Remeres 100% funcional com suporte a assets.
EN:
Support for loading items from a .Dat of a Spr and Dat has been added.
With this we can continue using spr and dat editors like the object builder to speed up the development of derived servers.
The asset editor is a great solution, but it has several problems. When trying to use it a few times to create derivative servers in the canary, I ended up giving up due to the large number of problems it presents when trying to work with it for a few hours open, modifying hundreds of items per hour.
With this support, the development of derivative servers such as Naruto, Pokemon, Dragon Ball and others becomes simpler, and more similar to what the entire derivatives community is already accustomed to.
Breaking a huge barrier among the derivatives community that remains on tfs due to the editors' facilities.
At least until we get an asset editor as good as ObjectBuilder and the finalization of 100% functional Remeres with asset support.
ff319024accbb0201f4653e6326e9f93.mp4
81b8bba1991aa22f029b0cca6fbd1e6b.mp4
a420ef4984392399570cd559ddcaa424.mp4
86afe2f50a645b6a4298dc128ee66704.mp4
How Has This Been Tested
Enable this
