Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exori Gran Con skill wheel bugged #3313

Open
3 of 5 tasks
mdbeng opened this issue Feb 1, 2025 · 9 comments · May be fixed by #3321
Open
3 of 5 tasks

Exori Gran Con skill wheel bugged #3313

mdbeng opened this issue Feb 1, 2025 · 9 comments · May be fixed by #3321
Labels
Priority: Critical Represents a risk to live servers Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@mdbeng
Copy link
Contributor

mdbeng commented Feb 1, 2025

Priority

Critical

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

When having the skill wheel to boost your exori gran con, you can make over 10k damage with 1 hit.

i tested it with a Paladin level 700 / skill 101

Image

Image

What OS are you seeing the problem on?

Windows, Linux

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mdbeng mdbeng added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Feb 1, 2025
@github-actions github-actions bot added Priority: Critical Represents a risk to live servers Status: Pending Test This PR or Issue requires more testing labels Feb 1, 2025
@mdbeng
Copy link
Contributor Author

mdbeng commented Feb 1, 2025

The problem is within PR 3122

@fugu320
Copy link

fugu320 commented Feb 3, 2025

From my tests, it seems that this applies to all spell bonuses from the wheel. It looks like the bonuses are not being subtracted in PvP, where you should be receiving 50% damage.

@lBaah
Copy link

lBaah commented Feb 3, 2025

This is due to wheel damage being calculated before the creature events at: https://github.com/opentibiabr/canary/blob/main/src/game/game.cpp#L7457

Move this whole creature event section to be here: https://github.com/opentibiabr/canary/blob/main/src/game/game.cpp#L7233

@paczielny
Copy link

This is due to wheel damage being calculated before the creature events at: https://github.com/opentibiabr/canary/blob/main/src/game/game.cpp#L7457

Move this whole creature event section to be here: https://github.com/opentibiabr/canary/blob/main/src/game/game.cpp#L7233

the solution is not understood

@lBaah
Copy link

lBaah commented Feb 3, 2025

This is due to wheel damage being calculated before the creature events at: https://github.com/opentibiabr/canary/blob/main/src/game/game.cpp#L7457
Move this whole creature event section to be here: https://github.com/opentibiabr/canary/blob/main/src/game/game.cpp#L7233

the solution is not understood

Move this block from the line 7457 on game.cpp to the line 7233 on game.cpp. Recompile and run.

if (damage.origin != ORIGIN_NONE) {
	const auto events = target->getCreatureEvents(CREATURE_EVENT_HEALTHCHANGE);
	if (!events.empty()) {
		for (const auto &creatureEvent : events) {
			creatureEvent->executeHealthChange(target, attacker, damage);
		}
		damage.origin = ORIGIN_NONE;
		return combatChangeHealth(attacker, target, damage);
	}
}

@mdbeng
Copy link
Contributor Author

mdbeng commented Feb 3, 2025

I will test it as well @lBaah thanks. if this works would you mind making the pr or should I make it?

@felipe2g
Copy link

felipe2g commented Feb 4, 2025

@lBaah that solution worked like a charm, do you will make a pr for this?

@lBaah
Copy link

lBaah commented Feb 4, 2025

I will not make a PR. You guys can create one. I'm only helping with some issues as they appear when I have the time.

@mdbeng mdbeng closed this as completed Feb 4, 2025
@mdbeng mdbeng linked a pull request Feb 4, 2025 that will close this issue
13 tasks
@murilo09
Copy link
Contributor

murilo09 commented Feb 4, 2025

No need to close the issue

@murilo09 murilo09 reopened this Feb 4, 2025
@murilo09 murilo09 linked a pull request Feb 4, 2025 that will close this issue
13 tasks
@murilo09 murilo09 removed a link to a pull request Feb 4, 2025
13 tasks
@murilo09 murilo09 linked a pull request Feb 4, 2025 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Critical Represents a risk to live servers Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants