[docker] correct radio URL in docker_entrypoint.sh #2699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukepo
reviewed
Feb 7, 2025
| @@ -81,7 +81,7 @@ trap shutdown TERM INT | |||
|
|
|||
| parse_args "$@" | |||
|
|
|||
| [ -n "$RADIO_URL" ] || RADIO_URL="spinel+hdlc+uart:///dev/ttyUSB0" | |||
There was a problem hiding this comment.
there's another combination: spinel+hdlc+forkpty, right?
There was a problem hiding this comment.
Sorry I missed it. We need to keep it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2699 +/- ##
===========================================
- Coverage 55.77% 43.29% -12.49%
===========================================
Files 87 108 +21
Lines 6890 13398 +6508
Branches 0 963 +963
===========================================
+ Hits 3843 5800 +1957
- Misses 3047 7290 +4243
- Partials 0 308 +308 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OT platform driver compares the radio URL with
spinel+hdlc.+uartis not needed.