Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dnssd-plat] integrate DnssdPlatform into Application #2677

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

superwhd
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.29%. Comparing base (2b41187) to head (aa455db).
Report is 941 commits behind head on main.

Files with missing lines Patch % Lines
src/host/posix/dnssd.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2677       +/-   ##
===========================================
- Coverage   55.77%   43.29%   -12.49%     
===========================================
  Files          87      108       +21     
  Lines        6890    13402     +6512     
  Branches        0      964      +964     
===========================================
+ Hits         3843     5802     +1959     
- Misses       3047     7292     +4245     
- Partials        0      308      +308     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superwhd superwhd force-pushed the otplatdnssd branch 2 times, most recently from a628b1b to 6554a0d Compare February 7, 2025 02:29
@superwhd superwhd marked this pull request as ready for review February 7, 2025 02:55
@superwhd superwhd changed the title [Don't review] [dnssd-plat] integrate DnssdPlatform into Application [dnssd-plat] integrate DnssdPlatform into Application Feb 7, 2025
@superwhd superwhd force-pushed the otplatdnssd branch 2 times, most recently from d42b3c2 to 6e525fa Compare February 7, 2025 04:46
@superwhd superwhd closed this Feb 7, 2025
@superwhd superwhd reopened this Feb 7, 2025
@superwhd superwhd requested review from abtink and Irving-cl February 7, 2025 06:41
Copy link
Contributor

@Irving-cl Irving-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

script/bootstrap Show resolved Hide resolved
@superwhd superwhd force-pushed the otplatdnssd branch 2 times, most recently from c6fcb81 to 59450f9 Compare February 8, 2025 01:45
@superwhd
Copy link
Contributor Author

superwhd commented Feb 8, 2025

The CI failure should be solved when #2702 is meregd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants