[ncp] implement dbus server for NCP mode #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2339 +/- ##
===========================================
- Coverage 55.77% 37.59% -18.18%
===========================================
Files 87 94 +7
Lines 6890 10668 +3778
Branches 0 766 +766
===========================================
+ Hits 3843 4011 +168
- Misses 3047 6457 +3410
- Partials 0 200 +200 ☔ View full report in Codecov by Sentry. |
Irving-cl
force-pushed
the
support_ncp_dbus
branch
from
e71e715 to
d63e2c2
Compare
Irving-cl
force-pushed
the
support_ncp_dbus
branch
3 times, most recently
from
4c63dd0 to
03edbdd
Compare
abtink
approved these changes
Jun 21, 2024
Irving-cl
force-pushed
the
support_ncp_dbus
branch
from
03edbdd to
ea63d86
Compare
superwhd
reviewed
Jun 25, 2024
Irving-cl
force-pushed
the
support_ncp_dbus
branch
3 times, most recently
from
41f531a to
9d81f99
Compare
Irving-cl
force-pushed
the
support_ncp_dbus
branch
4 times, most recently
from
23c07e3 to
ffedfef
Compare
superwhd
reviewed
Jun 25, 2024
Irving-cl
force-pushed
the
support_ncp_dbus
branch
from
ffedfef to
fa6534c
Compare
Irving-cl
force-pushed
the
support_ncp_dbus
branch
from
fa6534c to
c3fa90c
Compare
superwhd
reviewed
Jun 26, 2024
Irving-cl
force-pushed
the
support_ncp_dbus
branch
from
c3fa90c to
2769ff0
Compare
jwhui
reviewed
Jun 26, 2024
Comment on lines
57
to
58
| * @{ | ||
| * @} |
There was a problem hiding this comment.
I copied this from dbus_thread_object_rcp.hpp. But this is not correct. I fixed it in both headers.
jwhui
reviewed
Jun 26, 2024
Irving-cl
force-pushed
the
support_ncp_dbus
branch
from
2769ff0 to
6e07a29
Compare
Irving-cl
force-pushed
the
support_ncp_dbus
branch
from
6e07a29 to
b5a77cd
Compare
jwhui
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
DBusAgentso that it can work under NCP mode.The DBus server will provide different methods under RCP mode and NCP mode. Currently under NCP mode, only
GetDeviceRoleis provided.This PR renames
DBusThreadObjecttoDBusThreadObjectRcpand added a new classDBusThreadObjectNcpwhich will handle the DBus requests under NCP mode. This PR also implementsAsyncPropertyHandlerto handle GetProperty requests by calling async methods ofNcpHost.A test case is added to test
GetDeviceRoleunder NCP.This PR is also a breakdown of PR #2283.