feat(policy): KAS Keys #2051
Merged
feat(policy): KAS Keys #2051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-r33d
force-pushed
the
feature/key-management
branch
from
730b021 to
f8f5a95
Compare
c-r33d
force-pushed
the
feat/DSPX-678-KAS-key-management
branch
from
de8e592 to
abfe42d
Compare
There was a problem hiding this comment.
Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- service/policy/db/query.sql: Language not supported
Comments suppressed due to low confidence (1)
service/policy/kasregistry/key_access_server_registry_keys_test.go:56
- The test case for 'Invalid ID (invalid uuid)' is referencing 'errMessageUUID', which is not defined in the constants. Verify if the intended constant is 'errInvalidUUID' or update the error message constant accordingly.
errorMessage: errMessageUUID,
strantalis
reviewed
Apr 9, 2025
strantalis
approved these changes
Apr 11, 2025
linting. linting. remove accidental change. lint. lint. modify tests to use fixtures. continue, do not fail fast. refactor refactor refactor
c-r33d
force-pushed
the
feat/DSPX-678-KAS-key-management
branch
from
1deea0e to
bb6aa58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
1.) Add crud for adding keys to Key Access Server table
Checklist
Testing Instructions