Refactor SidebarNav to extract custom hooks #108
+140
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves the SidebarNav component by applying Single Responsibility Principle: - Extract useClickOutside hook: Handles click and touch events outside an element - Extract useEscapeKey hook: Handles Escape key press detection - Extract useScrollRestoration hook: Manages scroll position across re-renders - Extract useNavCollapseHandler hook: Handles nav collapse/expand with animation Benefits: - Reduces SidebarNavBase complexity from 121 lines to 77 lines (-36%) - Eliminates code duplication between SidebarNav and BodyPortalSidebarNav - Makes hooks reusable across other components - Improves testability by isolating concerns - Maintains backward compatibility with no breaking changes Related to CORE-1448 and CORE-1451 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
default values never used ref can be null
jomcarvajal
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the SidebarNav component to improve code organization by extracting four custom hooks, following Single Responsibility Principle as identified in CORE-1448.
Changes Made
useClickOutside - Detects clicks/touches outside a specified element
useEscapeKey - Detects Escape key press events
useScrollRestoration - Preserves scroll position across re-renders
useNavCollapseHandler - Handles nav collapse/expand with animation
Impact
Testing
Related Issues
🤖 Generated with Claude Code