Core-20: clear selection when user tab-navigates #2578
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
from
c960db6 to
eb2267e
Compare
Dantemss
reviewed
Oct 16, 2025
| if (!selection?.rangeCount) { | ||
| return; | ||
| } | ||
| const userRange = selection?.getRangeAt(0); |
There was a problem hiding this comment.
selection should always be defined by this point (after the early return check). Is TS complaining?
There was a problem hiding this comment.
Yeah, it's TS complaining. I'm sorry, this shouldn't be up for review yet. I was just trying to get a deployment.
| } | ||
|
|
||
| document.addEventListener('focusin', handleFocusChange); | ||
| document.addEventListener('focusout', handleFocusChange); |
There was a problem hiding this comment.
So any focus change at all clears the selected text?
There was a problem hiding this comment.
Yeah. That's the issue as I understand it: Otto would select some text, and then tab elsewhere and it would still be ready to create the highlight.
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
from
7c665b9 to
95a8381
Compare
Update EditCard.spec.tsx.snap
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
from
95a8381 to
9ec69a8
Compare
RoyEJohnson
force-pushed
the
core-20-fix-clear-highlight-when-user-moves-focus
branch
from
9ec69a8 to
1b5aca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-20