Skip to content

Update io-lifetimes requirement from 0.6 to 0.7 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 7, 2022

Updates the requirements on io-lifetimes to permit the latest version.

Commits
  • f5b4dea (cargo-release) version 0.7.0
  • 22ea30a Add From\<OwnedFd> and From\<T> for OwnedFd impls.
  • f80e1f0 Make drop functions which are usually no-ops inline.
  • e3b7794 Remove obsolete TODOs.
  • 1b91650 Remove sunfishcode.online docs.
  • a7da11e (cargo-release) version 0.7.0-beta.0
  • b3c7b00 Make views require dedicated unsafe marker traits. (#32)
  • d520244 (cargo-release) version 0.7.0-alpha.1
  • c974453 Avoid depending on panic in const fn, to fix compilaton on Rust <= 1.56.
  • 1fd4a53 (cargo-release) version 0.7.0-alpha.0
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [io-lifetimes](https://github.com/sunfishcode/io-lifetimes) to permit the latest version.
- [Release notes](https://github.com/sunfishcode/io-lifetimes/releases)
- [Commits](sunfishcode/io-lifetimes@v0.6.0...v0.7.0)

---
updated-dependencies:
- dependency-name: io-lifetimes
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 7, 2022
@jonhoo
Copy link
Collaborator

jonhoo commented Jun 7, 2022

This change is Reviewable

@NobodyXu NobodyXu merged commit 8884413 into master Jun 7, 2022
@NobodyXu NobodyXu deleted the dependabot/cargo/io-lifetimes-0.7 branch June 7, 2022 10:47
@jonhoo
Copy link
Collaborator

jonhoo commented Jun 7, 2022

Is io-lifetimes not part of any of our public types or methods?

@NobodyXu
Copy link
Member

NobodyXu commented Jun 8, 2022

Is io-lifetimes not part of any of our public types or methods?

No, it is only used internally.

@NobodyXu
Copy link
Member

NobodyXu commented Jun 8, 2022

@jonhoo It is used in StdioImpl

@jonhoo
Copy link
Collaborator

jonhoo commented Jun 12, 2022

@NobodyXu Ah, yes, this impl is problematic:

openssh/src/stdio.rs

Lines 78 to 82 in 8884413

impl From<OwnedFd> for Stdio {
fn from(fd: OwnedFd) -> Self {
Self(StdioImpl::Fd(fd))
}
}

We should probably turn that into an inherent implementation instead so that it can be pub(crate).

@NobodyXu
Copy link
Member

@NobodyXu Ah, yes, this impl is problematic:

openssh/src/stdio.rs

Lines 78 to 82 in 8884413

impl From<OwnedFd> for Stdio {
fn from(fd: OwnedFd) -> Self {
Self(StdioImpl::Fd(fd))
}
}

We should probably turn that into an inherent implementation instead so that it can be pub(crate).

Sorry that I didn't notice this.

But we would have to make a breaking change to remove that function.

Perhaps we should just revert this PR?

@jonhoo
Copy link
Collaborator

jonhoo commented Jun 13, 2022

I think we should just remove the impl with a minor release. It's extremely unlikely anyone is relying on this part of the API right now, and it's okay to do a theoretically-breaking change in a non-major release if the likelihood of actual breakage is as low as here I think.

@NobodyXu
Copy link
Member

I think we should just remove the impl with a minor release. It's extremely unlikely anyone is relying on this part of the API right now, and it's okay to do a theoretically-breaking change in a non-major release if the likelihood of actual breakage is as low as here I think.

Done in #82 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

2 participants