-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix response not showing in summary mode #3670
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3670 +/- ##
=======================================
Coverage 38.9% 38.9%
Complexity 1164 1164
=======================================
Files 284 284
Lines 15078 15078
Branches 2671 2671
=======================================
Hits 5872 5872
+ Misses 8361 8360 -1
- Partials 845 846 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you be more descriptive on what you're solving here?
And if it's possible, to add a test.
Description updated and a test added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
IMPORTANT: Where possible all PRs must be linked to a Github issue
This PR addresses some issues mentioned in this comment. The 2 spcific fixes done are:
When a questionnaire response was saved earlier as draft and later on retrieved in summary mode. The answers to the questionnaire items were empty because it searched for an in-progress QR rather than the one with completed status. This has been fixed in this commit.
I added a check in this commit to not to show save as draft option in Summary mode
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file