feat: fix null error

[tfhddd]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @tfhddd, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the email notification system by addressing a potential null pointer issue. It specifically adds a safeguard in the handleSendEmail function to verify the presence of the corporate administrator's name before proceeding, thus preventing crashes and providing clearer error feedback when this critical piece of information is missing.

Highlights

• Null Check Implementation: Introduced a null check for corp.Admin.Name within the handleSendEmail function to prevent potential runtime panics if the administrator's name is not available.
• Error Handling: Added specific error handling that returns a formatted error message if corp.Admin.Name is nil, ensuring graceful failure for email sending operations.
• Dependency Update: Imported the fmt package to facilitate the creation of formatted error messages.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request aims to fix a nil pointer dereference when sending a notification email. The change adds a nil check for the corporation admin's name. My review points out that there are other similar potential nil pointer issues in the same function for the admin's email address and the link's email address. I've suggested adding checks for these as well to make the function more robust and prevent future panics.

[gemini-code-assist]

While adding the nil check for corp.Admin.Name is a good fix, this function has other potential nil pointer dereferences that should also be handled. Specifically, corp.Admin.EmailAddr (used on line 171) and link.Email.Addr (used on line 170) could also be nil, leading to panics. It's best to add guard clauses for all of them at the beginning of the function for robustness. I've also updated the error messages to include the corporation ID for better context where applicable.

Suggested change

	if corp.Admin.Name == nil {
	return fmt.Errorf("failed to send email msg: admin name is null: %s", link.Id)
	}
	if corp.Admin.Name == nil {
	return fmt.Errorf("failed to send email msg: admin name is null for corp %s", corp.Id)
	}
	if corp.Admin.EmailAddr == nil {
	return fmt.Errorf("failed to send email msg: admin email is null for corp %s", corp.Id)
	}
	if link.Email.Addr == nil {
	return fmt.Errorf("failed to send email msg: link email address is null for link %s", link.Id)
	}