build: update target Windows SDK to latest version #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Windows build configuration to use the latest available Windows SDK version instead of a hardcoded specific version, resolving issue #717. The changes revert a temporary workaround and provide a more flexible, maintainable solution.
Key changes:
- Updated the Windows SDK target version from a specific version (10.0.22621.0) to automatically use the latest installed version (10.0)
- Reverted GitHub Actions workflow runners from
windows-2022towindows-latest
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| win/cobj/cobj.vcxproj | Changed WindowsTargetPlatformVersion to use "10.0" to automatically target the latest installed SDK |
| .github/workflows/windows-test.yml | Reverted runner specification from windows-2022 to windows-latest |
| .github/workflows/windows-build.yml | Reverted runner specification from windows-2022 to windows-latest |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
yutaro-sakamoto
approved these changes
Oct 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Code Changes
10.0.22621.0to target the latest installed version.