Skip to content

Conversation

@maxcao13
Copy link
Member

This commit configures a new presubmit job for o/k that only focuses on the HPA. It runs these tests with a test parallelism of 3, down from the default of 30. This is because the HPA tests use a lot of request resources in the tests themselves.

In order to do this, it exposes two new envs for the openshift-kubernetes-e2e-test ref. These are:

  • NODES: configure ginkgo test parallelism
  • KUBE_E2E_TEST_ARGS: allows test argument overrides for the ginkgo runner within the o/k test-kubernetes-e2e.sh script.

There is a long tail of history for this change and relevant slack conversations.

See:
Upstream issue: kubernetes/kubernetes#135026
PR to re-enable tests: openshift/kubernetes#2492
Test PR that shows that this configuration works: #71086

This commit configures a new presubmit job for o/k that only focuses on the HPA.
It runs these tests with a test parallelism of 3, down from the default of 30.

In order to do this, it exposes two new envs for the openshift-kubernetes-e2e-test ref.
These are:
- NODES: configure ginkgo test parallelism
- KUBE_E2E_TEST_ARGS: allows test argument overrides for the ginkgo runner within the o/k test-kubernetes-e2e.sh script.

Signed-off-by: Max Cao <[email protected]>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 10, 2025
@openshift-ci-robot
Copy link
Contributor

@maxcao13: This pull request references Jira Issue OCPBUGS-61376, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @prozehna

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This commit configures a new presubmit job for o/k that only focuses on the HPA. It runs these tests with a test parallelism of 3, down from the default of 30. This is because the HPA tests use a lot of request resources in the tests themselves.

In order to do this, it exposes two new envs for the openshift-kubernetes-e2e-test ref. These are:

  • NODES: configure ginkgo test parallelism
  • KUBE_E2E_TEST_ARGS: allows test argument overrides for the ginkgo runner within the o/k test-kubernetes-e2e.sh script.

There is a long tail of history for this change and relevant slack conversations.

See:
Upstream issue: kubernetes/kubernetes#135026
PR to re-enable tests: openshift/kubernetes#2492
Test PR that shows that this configuration works: #71086

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maxcao13
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maxcao13
Copy link
Member Author

This PR requires openshift/kubernetes#2492 to be merged.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@maxcao13: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-kube-apiserver-operator-main-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.22-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.21-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.20-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.19-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.18-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.16-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.15-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.14-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.13-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.12-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.11-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.10-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.9-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.8-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.7-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.6-k8s-e2e-gcp openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-main-k8s-e2e-gcp-serial openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.22-k8s-e2e-gcp-serial openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.21-k8s-e2e-gcp-serial openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.20-k8s-e2e-gcp-serial openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.19-k8s-e2e-gcp-serial openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.18-k8s-e2e-gcp-serial openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-k8s-e2e-gcp-serial openshift/cluster-kube-apiserver-operator presubmit Registry content changed

A total of 118 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2025

@maxcao13: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants