Skip to content

Conversation

@pruan-rht
Copy link
Member

Reverts #69966

@openshift-ci openshift-ci bot requested review from psalajova and smg247 October 29, 2025 20:33
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2025
@pruan-rht
Copy link
Member Author

it's causing issue with validation... FYI @pgstorm148 please test your PR before submitting it.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 29, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@pruan-rht: no rehearsable tests are affected by this change

@stbenjam
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pruan-rht, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pruan-rht
Copy link
Member Author

@pgstorm148 it looks like you changed the way it finds the config.yaml file
from

base_dir=.

cd "${base_dir}/core-services/prow/02_config"

to

repo_root="$(get_repo_root)"
    local config_dir="${repo_root}/core-services/prow/02_config"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

@pruan-rht: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit aa7a86f into openshift:master Oct 29, 2025
6 checks passed
@pgstorm148
Copy link
Contributor

Hey @pruan-rht ,
I tested the changes before pushing it. But if it's failing then no probs, thanks for reverting the code.
Yes the PR contained multiple changes which were present there.

Thank you

@pruan-rht
Copy link
Member Author

@pgstorm148 I think if you keep the original way of setting the basedir then it should work

@pgstorm148
Copy link
Contributor

Yeah, maybe I will test again. But thanks for letting me know the Root cause.
@pruan-rht

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants