-
Notifications
You must be signed in to change notification settings - Fork 2k
Revert "hack: improve validate-boskos.sh with better error handling - Add dy…" #70836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "hack: improve validate-boskos.sh with better error handling - Add dy…" #70836
Conversation
… Add dy…" This reverts commit d901dee.
|
it's causing issue with validation... FYI @pgstorm148 please test your PR before submitting it. |
|
[REHEARSALNOTIFIER] |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pruan-rht, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pgstorm148 it looks like you changed the way it finds the config.yaml file to |
|
@pruan-rht: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hey @pruan-rht , Thank you |
|
@pgstorm148 I think if you keep the original way of setting the basedir then it should work |
|
Yeah, maybe I will test again. But thanks for letting me know the Root cause. |
Reverts #69966