Skip to content

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Oct 2, 2025

It has been on in origin for a few weeks, we think its a small improvement to both avoiding flakes and detecting regressions on tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 2, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 2, 2025

@stbenjam: This pull request references TRT-2288 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 2, 2025

@stbenjam: This pull request references TRT-2288 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

It has been on in origin for a few weeks, we think its a small improvement to both avoiding flakes and detecting regressions on tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2025
@openshift-ci openshift-ci bot requested review from dhensel-rh and smg247 October 2, 2025 15:37
@stbenjam
Copy link
Member Author

stbenjam commented Oct 2, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@stbenjam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@stbenjam, pj-rehearse: unable to determine affected jobs ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout 56ac5fc458bf9bfb854557f832eb205889c01324]' failed with out:  and error exec: Stdout already set

If the problem persists, please contact Test Platform.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@stbenjam: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-node-tuning-operator-main-e2e-aws-ovn openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-main-e2e-aws-ovn-techpreview openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-main-okd-scos-e2e-aws-ovn openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.22-e2e-aws-ovn openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.22-e2e-aws-ovn-techpreview openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.21-e2e-aws-ovn openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.21-e2e-aws-ovn-techpreview openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.20-e2e-aws-ovn openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.20-e2e-aws-ovn-techpreview openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.20-okd-scos-e2e-aws-ovn openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.19-okd-scos-e2e-aws-ovn openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.19-e2e-aws-ovn openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.19-e2e-aws-ovn-techpreview openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.18-okd-scos-e2e-aws-ovn openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.18-e2e-aws-ovn openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.18-e2e-aws-ovn-techpreview openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.17-e2e-aws-ovn openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.17-e2e-aws-ovn-techpreview openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.16-e2e-aws-ovn openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.16-e2e-aws-ovn-techpreview openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.15-e2e-aws-ovn openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.15-e2e-aws-ovn-techpreview openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.14-e2e-aws-ovn openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.13-e2e-aws-ovn openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.12-e2e-aws-ovn openshift/cluster-node-tuning-operator presubmit Registry content changed

A total of 16209 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@stbenjam
Copy link
Member Author

stbenjam commented Oct 2, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@stbenjam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@stbenjam
Copy link
Member Author

stbenjam commented Oct 2, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@stbenjam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@smg247
Copy link
Member

smg247 commented Oct 2, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, smg247, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/eclipse-che/che-dashboard/main/v19-dashboard-happy-path 9ca8b0a link unknown /pj-rehearse pull-ci-eclipse-che-che-dashboard-main-v19-dashboard-happy-path
ci/rehearse/openshift/baremetal-runtimecfg/release-4.7/e2e-metal-ipi 9ca8b0a link unknown /pj-rehearse pull-ci-openshift-baremetal-runtimecfg-release-4.7-e2e-metal-ipi
ci/rehearse/openshift/baremetal-runtimecfg/release-4.5/e2e-metal-ipi 9ca8b0a link unknown /pj-rehearse pull-ci-openshift-baremetal-runtimecfg-release-4.5-e2e-metal-ipi
ci/rehearse/openshift/baremetal-runtimecfg/release-4.6/e2e-metal-ipi 9ca8b0a link unknown /pj-rehearse pull-ci-openshift-baremetal-runtimecfg-release-4.6-e2e-metal-ipi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stbenjam
Copy link
Member Author

stbenjam commented Oct 2, 2025

I don't like the rehearsals it picked.

/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn pull-ci-openshift-installer-release-4.19-e2e-aws-ovn

@openshift-ci-robot
Copy link
Contributor

@stbenjam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@stbenjam
Copy link
Member Author

stbenjam commented Oct 3, 2025

/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn pull-ci-openshift-installer-release-4.19-e2e-aws-ovn

@openshift-ci-robot
Copy link
Contributor

@stbenjam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@stbenjam
Copy link
Member Author

stbenjam commented Oct 6, 2025

/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn pull-ci-openshift-installer-release-4.19-e2e-aws-ovn

@openshift-ci-robot
Copy link
Contributor

@stbenjam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@stbenjam
Copy link
Member Author

stbenjam commented Oct 6, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@stbenjam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 6, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit cf60d41 into openshift:master Oct 6, 2025
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants