Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MULTIARCH-5196: updated parameters for tfvars #60307

Merged
merged 2 commits into from
Jan 6, 2025
Merged

MULTIARCH-5196: updated parameters for tfvars #60307

merged 2 commits into from
Jan 6, 2025

Conversation

prb112
Copy link
Contributor

@prb112 prb112 commented Jan 3, 2025

No description provided.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 3, 2025 •
edited by openshift-ci bot
Loading

@prb112: This pull request references MULTIARCH-5196 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 3, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2025
@prb112
Copy link
Contributor Author

prb112 commented Jan 3, 2025

/assign @pkenchap
/assign @mpkredhat

@openshift-ci openshift-ci bot requested review from dgoodwin and xueqzhan January 3, 2025 18:02
@prb112
Copy link
Contributor Author

prb112 commented Jan 3, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@prb112: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 3, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025
@pkenchap
Copy link
Contributor

pkenchap commented Jan 6, 2025

/lgtm

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d0011b2 and 2 for PR HEAD 1b3f6e8 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d758942 and 1 for PR HEAD 1b3f6e8 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a3c4cdc and 2 for PR HEAD 1b3f6e8 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8f8c7c9 and 1 for PR HEAD 1b3f6e8 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8f8c7c9 and 2 for PR HEAD 1b3f6e8 in total

@prb112
fix for spellcheck
e7054a9 
Signed-off-by: Paul Bastide <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@prb112: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-multiarch-master-nightly-4.19-ocp-e2e-powervs-ovn-multi-p-px N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-powervs-ovn-multi-p-px N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.16-ocp-e2e-powervs-ovn-multi-ppc64le N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.18-ocp-e2e-powervs-ovn-multi-p-px N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.15-ocp-e2e-powervs-ovn-multi-ppc64le N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 6, 2025
@prb112
Copy link
Contributor Author

prb112 commented Jan 6, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@prb112: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 6, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

@prb112: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025
@pkenchap
Copy link
Contributor

pkenchap commented Jan 6, 2025

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pkenchap, prb112

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0d7b07c into openshift:master Jan 6, 2025
10 checks passed
Phaow pushed a commit to Phaow/release that referenced this pull request Jan 10, 2025
@prb112 @Phaow
MULTIARCH-5196: updated parameters for tfvars (openshift#60307)
ec74dff 
* MULTIARCH-5196: updated parameters for tfvars

Signed-off-by: Paul Bastide <[email protected]>

* fix for spellcheck

Signed-off-by: Paul Bastide <[email protected]>

---------

Signed-off-by: Paul Bastide <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkenchap pkenchap pkenchap approved these changes

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

@xueqzhan xueqzhan Awaiting requested review from xueqzhan

Assignees

@pkenchap pkenchap

@mpkredhat mpkredhat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prb112 @openshift-ci-robot @pkenchap @mpkredhat