CM-462: refactor custom-api-ingress-cert related CI steps

[lunarwhite]

Main changes:

• Updated CI steps definition to expose ENV and trim unnecessary claims.
• Added checkpoints to check prerequisites like dependencies readiness.
• Defined common functions which is super useful to reuse within and across shell scripts.
• Adpoted oc wait instead of raw while-loop for better readability and maintenance.
• Switched to use the Console route for the Ingress post-check.
• Tweaked comments for better documentation.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[lunarwhite]

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-aws-ipi-byo-iam-role-efs-mini-perm-arm-f2-custom-cert periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-byo-iam-role-efs-arm-f28-custom-cert periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-azure-aks-hypershift-full-cert-guest-f14 periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-azure-aks-hypershift-full-cert-guest-f14

[openshift-ci-robot]

@lunarwhite: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[lunarwhite]

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-aws-ipi-byo-iam-role-efs-mini-perm-arm-f2-custom-cert periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-byo-iam-role-efs-arm-f28-custom-cert

[openshift-ci-robot]

@lunarwhite: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[lunarwhite]

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-aws-ipi-byo-iam-role-efs-mini-perm-arm-f2-custom-cert periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-byo-iam-role-efs-arm-f28-custom-cert

[openshift-ci-robot]

@lunarwhite: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[lunarwhite]

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-aws-ipi-byo-iam-role-efs-mini-perm-arm-f2-custom-cert periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-byo-iam-role-efs-arm-f28-custom-cert

[openshift-ci-robot]

@lunarwhite: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[lunarwhite]

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert

[openshift-ci-robot]

@lunarwhite: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[lunarwhite]

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-byo-iam-role-efs-arm-f28-custom-cert

[openshift-ci-robot]

@lunarwhite: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[lunarwhite]

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-byo-iam-role-efs-arm-f28-custom-cert periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert

[openshift-ci-robot]

@lunarwhite: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci-robot]

@lunarwhite: This pull request references CM-462 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

TBD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@lunarwhite: This pull request references CM-462 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Main changes:

• Updated CI steps definition to expose ENV and trim unnecessary claims.
• Added checkpoints to check prerequisites like dependencies readiness.
• Defined common functions which is super useful to reuse within and across shell scripts.
• Adpoted oc wait instead of raw while-loop for better readability and maintenance.
• Switched to use the Console route for the Ingress post-check.
• Tweaked comments for better documentation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lunarwhite]

Rehearsed some CI jobs that invoke changed Refs, results:

periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-byo-iam-role-efs-arm-f28-custom-cert: https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/pr-logs/pull/openshift_release/60303/rehearse-60303-periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-byo-iam-role-efs-arm-f28-custom-cert/1875582968777412608

openshift-extended-test:
  total: 991
  failures: 5
  errors: 0
  skipped: 316
cucushift-e2e:
  total: 334
  failures: 0
  errors: 0
  skipped: 1

periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert: https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/pr-logs/pull/openshift_release/60303/rehearse-60303-periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert/1875582968806772736

openshift-extended-test:
  total: 1037
  failures: 4
  errors: 0
  skipped: 391
cucushift-e2e:
  total: 334
  failures: 1
  errors: 0
  skipped: 1

periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert: https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/pr-logs/pull/openshift_release/60303/rehearse-60303-periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert/1875582968693526528

openshift-extended-test:
  total: 1083
  failures: 4
  errors: 0
  skipped: 389
cucushift-e2e:
  total: 333
  failures: 1
  errors: 0
  skipped: 1

The pass ratio is quite high and there is no decrease compared to the job results prior to this PR. (Note: The azure-aks-hypershift-full-cert-guest jobs were failing due to the cluster provision error, which is not related to this PR.)

[openshift-ci]

@lunarwhite: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-azure-aks-hypershift-full-cert-guest-f14	27440dc	link	unknown	/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-azure-aks-hypershift-full-cert-guest-f14
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-azure-aks-hypershift-full-cert-guest-f14	27440dc	link	unknown	/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-azure-aks-hypershift-full-cert-guest-f14
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert	805189e	link	unknown	/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-byo-iam-role-efs-arm-f28-custom-cert	805189e	link	unknown	/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-byo-iam-role-efs-arm-f28-custom-cert
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert	805189e	link	unknown	/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[lunarwhite]

Rehearsal results see: #60303 (comment)

/pj-rehearse ack
/lgtm

[openshift-ci]

@lunarwhite: you cannot LGTM your own PR.

In response to this:

Rehearsal results see: #60303 (comment)

/pj-rehearse ack
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@lunarwhite: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@lunarwhite: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-azure-aks-hypershift-full-cert-guest-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-aws-ipi-byo-iam-role-efs-mini-perm-arm-f2-custom-cert	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-4.18-upgrade-from-stable-4.18-aws-ipi-byo-iam-role-efs-mini-perm-arm-f60-custom-cert	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-aws-ipi-byo-iam-role-efs-mini-perm-arm-f7-custom-cert	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-4.17-upgrade-from-stable-4.17-aws-ipi-byo-iam-role-efs-arm-f60-custom-cert	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-4.19-upgrade-from-stable-4.18-aws-ipi-byo-iam-role-efs-fips-amd-f28-custom-cert	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-azure-aks-hypershift-full-cert-guest-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-azure-aks-hypershift-full-cert-guest-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-byo-iam-role-efs-arm-f28-custom-cert	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-aws-ipi-byo-iam-role-efs-arm-f7-custom-cert	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-4.18-upgrade-from-stable-4.17-aws-ipi-byo-iam-role-efs-fips-amd-f28-custom-cert	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-4.17-upgrade-from-stable-4.16-aws-ipi-byo-iam-role-efs-fips-amd-f28-custom-cert	N/A	periodic	Registry content changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[hector-vido]

/retest

[KeenonLee]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KeenonLee, lunarwhite

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ci-operator/step-registry/cert-manager/OWNERS [lunarwhite]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lunarwhite]

/pj-rehearse ack

[openshift-ci-robot]

@lunarwhite: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.