[DNM] Bump1.34 GO 1.24 pre-merge test #2870
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Yurchenko <[email protected]>
Signed-off-by: Mykola Yurchenko <[email protected]>
Signed-off-by: Mykola Yurchenko <[email protected]>
- not to update the DPU connection status annotation on pod if pod is to be deleted - return failure if Acl log meter failed to be created Signed-off-by: Yun Zhou <[email protected]>
Signed-off-by: Mykola Yurchenko <[email protected]>
Remove --subresource=status from ovnkube.sh get_node_zone
Signed-off-by: Patryk Matuszak <[email protected]>
Fixes issues were introduced by adb1fc8 The core problem is that with the change to move the networkID from nodes to NADs, the upgrade logic left a gap in time where pods could not start. This because cluster-manager was responsible for migrating the networkID from the node->NAD, and in our upgrade strategy, workers upgrade before control plane nodes. This would leave worker nodes in a state where new OVNK code was running that was only looking for the networkID on the NAD, but it had not yet been migrated. This patch changes the behavior so that any NAD Controller (zone, node, or cluster manager) will attempt at start up to find NADs that are missing networkIDs and search nodes for the legacy values. Node and Zone NAD controllers will fallback to the legacy ID, but will not annotate the NAD. Cluster manager will also use the legacy ID and update the NAD with it. Unit tests added to cover the different scenarios. Signed-off-by: Tim Rozet <[email protected]>
Fixes NAD Controller syncAll for networkID upgrade from node->NAD
When a namespace/pod/EgressIP label update causes it to move from one EIP to another,
the EIP controller may process the associated EIPs in an order that leads
to incorrect assignment behavior.
Example Scenario:
1. Two EIPs exist:
* eip1 matches namespace label test: qe
* eip2 matches namespace label test: dev
2. Namespace ns1 initially has label test: dev and is served by eip2.
3. The label on ns1 is updated from test: dev to test: qe.
4. The EIP controller processes the Namespace update event:
Step 1: eip1 is processed first but skips assignment since the pod is already
served by eip2.
* In reconcileEgressIPNamespace, eip1 is processed first and matches the new
Namespace object.
* It invokes addNamespaceEgressIPAssignments → addPodEgressIPAssignments for
the pod, detect that eip2 (not yet processed) is still serving the pod, adds
eip1 to podState.standbyEgressIPNames, and returns.
Step 2: eip2 is processed next, matches the old Namespace object, and deletes
the pod from the assignment cache.
* In deleteNamespaceEgressIPAssignment → deletePodEgressIPAssignments, it cleans
up OVN entries (LRP, SNAT, and address sets) and removes the pod’s status entry
from podAssignment cache.
As a result, ns1 is no longer assigned to eip1
Fix:
When eip2 is processed in the deletePodEgressIPAssignments method, promote eip1
from standby EgressIP to active.
The same issue might also occur during Pod label updates or EgressIP selector
label updates (Namespace or Pod selector).
Added unit tests to cover Namespace, Pod, and EgressIP label update scenarios
to reproduce the issue and verify the fix.
Signed-off-by: Periyasamy Palanisamy <[email protected]>
Signed-off-by: Surya Seetharaman <[email protected]>
Signed-off-by: Surya Seetharaman <[email protected]>
This commit adds the CR validations tests for the API against a real kube-api server running in our CI lanes. It ensures invalid scenarios are caught and valid ones are allowed correctly. It's a test to ensure our CEL and kubebuilder validations hold well. Signed-off-by: Surya Seetharaman <[email protected]>
Signed-off-by: Surya Seetharaman <[email protected]>
Signed-off-by: Surya Seetharaman <[email protected]>
With multiple subnets for a network, only the first one was being used for cluster subnet exclusion. Signed-off-by: Tim Rozet <[email protected]>
miscellaneous fixes
Signed-off-by: Yun Zhou <[email protected]>
Refresh PID when calling OVS/OVN binaries
Fixes regression with ecabc89
Add `ClusterNetworkConnect` API
> go-controller go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get sigs.k8s.io/[email protected] go get k8s.io/[email protected] go get sigs.k8s.io/structured-merge-diff/[email protected] go get sigs.k8s.io/[email protected] go get k8s.io/[email protected] go get sigs.k8s.io/apiserver-network-proxy/[email protected] go get k8s.io/kube-openapi go get sigs.k8s.io/json go get k8s.io/utils go get github.com/openshift/api go get github.com/openshift/client-go go get golang.org/x/[email protected] go mod tidy go mod vendor > Update 1.Update GO version in go.mod and Makefile 2.Update hack/lint.sh to v2.5.0, which uses “golangci-lint migrate” [Refer to: https://golangci-lint.run/docs/product/migration-guide/ ] . 3.“typecheck” isn’t a linter and it runs automatically. So we don’t need it anymore in golangci-lint.yml [Refer to: https://golangci-lint.run/docs/welcome/faq/#why-do-you-have-typecheck-errors ] 4.after golangci-lint version 2, staticcheck has a new feature: quickfix(QF) [https://staticcheck.dev/docs/checks#QF ]. It will affect lint results, so disable all QF checks first. > Fix 1.Fix TypeConverter undefined errors in pkg/crd/…/v1/apislyconfiguration/utils.go: update these versions in go-controller/hack/update-codegen.sh and run "make codegen" GO111MODULE=on go install sigs.k8s.io/controller-tools/cmd/[email protected] GO111MODULE=on go install $(printf "k8s.io/code-generator/cmd/%[email protected] " "${BINS[@]}") 2.Fix staticcheck and testifylint errors: 11 issues: * staticcheck: 7 * testifylint: 4 Signed-off-by: Meina-rh <[email protected]>
> test/e2e go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get sigs.k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/kube-openapi go get golang.org/x/[email protected] go mod tidy > Fix e2e test failure > Skip k8s e2e tests [sig-network] Services [It] should support named targetPorts that resolve to different ports on different endpoints [sig-network] [sig-network] Conntrack [It] should be able to cleanup conntrack entries when UDP service target port changes for a NodePort service [sig-network] Signed-off-by: Meina-rh <[email protected]>
> test/conformance go get k8s.io/[email protected] go get k8s.io/[email protected] go get k8s.io/kube-openapi go get k8s.io/utils go get sigs.k8s.io/structured-merge-diff/[email protected] go get sigs.k8s.io/[email protected] go get sigs.k8s.io/[email protected] go mod tidy make conformance > Delete suite.SupportAdminNetworkPolicyEgressInlineCIDRPeers and suite.SupportBaselineAdminNetworkPolicyEgressInlineCIDRPeers Signed-off-by: Meina-rh <[email protected]>
> Update kubernetes version in the files below:
github/workflows/test.xml
contrib/kind-common
test/scripts/upgrade-ovn.sh
test/scripts/install-kind.sh
docs/installation/launching-ovn-kubernetes-on-kind.md
docs/developer-guide/local_testing_guide.md
> Update golangci-lint and golangci-lint-action in .github/workflows/test.xml
> Fix:
# golang.org/x/tools/internal/tokeninternal
Error: /home/runner/go/pkg/mod/golang.org/x/[email protected]/internal/tokeninternal/tokeninternal.go:78:9: invalid array length -delta * delta (constant -256 of type int64)
this error occurs because some dependencies are incompatible with go1.25:
1.in "coredns-ocp-dnsnameresolver/operator" CONTROLLER_TOOLS_VERSION=v0.14.0 isn't compatible with go1.25, specify CONTROLLER_TOOLS_VERSION=v0.19.0 in kind-common
2.in kind-common install_metallb() controller_gen_version = "v0.16.3" isn't compatible with go1.25, upgrade to controller_gen_version = "v0.19.0"
Signed-off-by: Meina-rh <[email protected]>
Signed-off-by: Peng Liu <[email protected]>
Comparing or setting a variable of type time.Duration to an integer, the integer is considered to be in nanoseconds Signed-off-by: Meina-rh <[email protected]>
cleanup primary pUDN connection details annotaton in cmdDel
go was bumped to 1.25 with the k8s bump to 1.34. This was a mistake as k8s did not bump golang and stayed on 1.24 this time. Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Meina-rh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Author
|
/retest-required |
Contributor
|
@Meina-rh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
Fixes #
Additional Information for reviewers
✅ Checks
How to verify it