Skip to content

[WIP][release-4.20] OCPBUGS-63171: Add imagestream update dryrun test #30389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: release-4.20
Choose a base branch
from
Open

[WIP][release-4.20] OCPBUGS-63171: Add imagestream update dryrun test #30389

wants to merge 2 commits into from

Conversation

wangke19
Copy link
Contributor

@wangke19 wangke19 commented Oct 16, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 16, 2025
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-63171, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

cherry-pick of #30357 by AI Cursor.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19 wangke19 mentioned this pull request Oct 16, 2025
Closed
@wangke19 wangke19 marked this pull request as ready for review October 16, 2025 05:37
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2025
@wangke19 wangke19 changed the title [release-4.20] OCPBUGS-63171: Add imagestream update dryrun test [WIP][release-4.20] OCPBUGS-63171: Add imagestream update dryrun test Oct 16, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2025
@wangke19 wangke19 force-pushed the backport-30357-to-release-4.20 branch 3 times, most recently from fa5ab16 to 1fb101e Compare October 16, 2025 06:28
@wangke19
add more images dryrun tests
a1c13ed
@wangke19
fix: exclude OLM index.json from JSON validation and update generated…
aaef791 
… annotations

- Add test/extended/util/compat_otp/testdata/opm/render/validate/catalog-error/operator-2/index.json to excluded files list in verify-jsonformat.sh
- Update generated annotations file with new test annotation for Image --dry-run should not update resources
@wangke19 wangke19 force-pushed the backport-30357-to-release-4.20 branch from 1fb101e to aaef791 Compare October 16, 2025 08:28
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wangke19
Once this PR has been reviewed and has the lgtm label, please assign flavianmissi, knobunc, sebsoto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

@wangke19: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flavianmissi flavianmissi Awaiting requested review from flavianmissi

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wangke19 @openshift-ci-robot