Skip to content

Conversation

Amarthya-v
Copy link

@Amarthya-v Amarthya-v commented Oct 8, 2025

Avoid attempting to create existing namespaces like kube-system which triggers managed-cluster-validating-webhooks in ROSA.

This reverts commit 46bbe12.
Follows #30352

Resolves: SREP-2020

… attempting to create existing namespaces like kube-system which triggers managed-cluster-validating-webhooks in ROSA."

This reverts commit 46bbe12.
@openshift-ci openshift-ci bot requested review from pperiyasamy and tssurya October 8, 2025 18:09
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Amarthya-v
Once this PR has been reviewed and has the lgtm label, please assign pliurh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

@Amarthya-v: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-2of2 ede6286 link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-gcp-ovn-upgrade ede6286 link true /test e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tssurya
Copy link
Contributor

tssurya commented Oct 9, 2025

@sdodson PTAL this PR since original one was approved by you: #30331 I unfortunately don't have enough context to approve this one.

@sdodson
Copy link
Member

sdodson commented Oct 9, 2025

@Amarthya-v Is this already reverted on master?

@sdodson
Copy link
Member

sdodson commented Oct 9, 2025

I see #30352 for master, we'll also need this picked back to release-4.20 too. Can you open a bug for this change on master branch so that we can properly link everything together?

@Amarthya-v
Copy link
Author

I see #30352 for master, we'll also need this picked back to release-4.20 too. Can you open a bug for this change on master branch so that we can properly link everything together?

@sdodson Thank you! below are the revert PRs and Jira ticket created

All linked together now.

@sdodson
Copy link
Member

sdodson commented Oct 13, 2025

Is the webhook already reverted? The ticket reads like it will be in the future.

@Amarthya-v
Copy link
Author

Is the webhook already reverted? The ticket reads like it will be in the future.

webhook revert has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants