Skip to content

Conversation

bertinatto
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 7, 2025
@openshift-ci openshift-ci bot requested review from dusk125 and everettraven October 7, 2025 17:59
@openshift-ci openshift-ci bot added e2e-images-update Related to images used by e2e tests vendor-update Touching vendor dir or related files labels Oct 7, 2025
@openshift-trt
Copy link

openshift-trt bot commented Oct 8, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: baf6499

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-csi Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-csi Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-csi Medium - "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-csi Medium - "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.

New tests seen in this PR at sha: baf6499

  • "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2025
@openshift-trt
Copy link

openshift-trt bot commented Oct 9, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 676f67d

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-csi Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-csi Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-csi Medium - "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-csi Medium - "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.

New tests seen in this PR at sha: 676f67d

  • "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]

@bertinatto
Copy link
Member Author

/retest

1 similar comment
@bertinatto
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2025
@bertinatto bertinatto changed the title WIP: Rebase 1.34 OCPSTRAT-2371: Update to Kubernetes v1.34.1 Oct 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2025

@bertinatto: This pull request references OCPSTRAT-2371 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 15, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2025
@bertinatto bertinatto changed the title OCPSTRAT-2371: Update to Kubernetes v1.34.1 WIP: OCPSTRAT-2371: Update to Kubernetes v1.34.1 Oct 15, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2025
@bertinatto bertinatto force-pushed the rebase-1.34 branch 2 times, most recently from e1b3ed7 to defaeac Compare October 17, 2025 17:08
@bertinatto bertinatto changed the title WIP: OCPSTRAT-2371: Update to Kubernetes v1.34.1 OCPSTRAT-2371: Update to Kubernetes v1.34.1 Oct 17, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2025
@bertinatto
Copy link
Member Author

/hold
For payload validation.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2025
@bertinatto
Copy link
Member Author

/retest

@openshift-trt
Copy link

openshift-trt bot commented Oct 19, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 5665b85

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-csi High - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-csi High - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-gcp-csi Medium - "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-csi Medium - "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.

New tests seen in this PR at sha: 5665b85

  • "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]

@bertinatto
Copy link
Member Author

/retest

@bertinatto
Copy link
Member Author

/test e2e-aws-ovn-serial-1of2

@bertinatto
Copy link
Member Author

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bertinatto
Copy link
Member Author

/retest

@bertinatto
Copy link
Member Author

/payload 4.21 nightly blocking
/payload 4.21 nightly informing
/payload 4.21 ci blocking

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

@bertinatto: trigger 13 job(s) of type blocking for the nightly release of OCP 4.21

  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-upgrade-fips
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-2of2
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-1of3
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-2of3
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-3of3
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c490e340-aec7-11f0-8798-21d963777354-0

trigger 68 job(s) of type informing for the nightly release of OCP 4.21

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-agent-compact-fips
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-agent-ha-dualstack-conformance
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-agent-single-node-ipv6-conformance
  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-azure-aks-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.21-console-aws
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.21-periodics-e2e-aws
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-csi
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-cgroupsv2
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-fips
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-single-node-csi
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-single-node-serial
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-single-node-techpreview
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-single-node-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.21-upgrade-from-stable-4.20-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-upgrade-out-of-change
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-upi
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.21-periodics-e2e-azure
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-azure-csi
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade-out-of-change
  • periodic-ci-openshift-release-master-cnv-nightly-4.21-deploy-azure-kubevirt-ovn
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.21-periodics-e2e-gcp
  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-gcp-ovn-csi
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-gcp-ovn-rt
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-gcp-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-azure-kubevirt-ovn
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-dualstack
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-dualstack-techpreview
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6-techpreview
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-serial-ipv4
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-serial-virtualmedia-1of2
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-serial-virtualmedia-2of2
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-techpreview
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.21-upgrade-from-stable-4.20-e2e-metal-ipi-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-serial-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-serial-ovn-dualstack
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-upgrade-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.21-upgrade-from-stable-4.20-e2e-metal-ipi-upgrade-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.21-metal-ovn-single-node-recert-cluster-rename
  • periodic-ci-openshift-osde2e-main-nightly-4.21-osd-aws
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-osd-ccs-gcp
  • periodic-ci-openshift-osde2e-main-nightly-4.21-osd-gcp
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-proxy
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ovn-single-node-live-iso
  • periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.21-nightly-x86-payload-control-plane-6nodes
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-telco5g
  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-csi
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-serial
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-techpreview
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.21-e2e-vsphere-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-vsphere-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-upi
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-upi-serial
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c490e340-aec7-11f0-8798-21d963777354-1

trigger 5 job(s) of type blocking for the ci release of OCP 4.21

  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aks
  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c490e340-aec7-11f0-8798-21d963777354-2

@bertinatto
Copy link
Member Author

/retest

@openshift-trt
Copy link

openshift-trt bot commented Oct 21, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 73e7fae

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-csi Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-csi Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-csi Medium - "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-csi Medium - "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.

New tests seen in this PR at sha: 73e7fae

  • "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]

@bertinatto
Copy link
Member Author

/payload 4.21 nightly blocking
/payload 4.21 nightly informing
/payload 4.21 ci blocking

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2025

@bertinatto: trigger 13 job(s) of type blocking for the nightly release of OCP 4.21

  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-upgrade-fips
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-2of2
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-1of3
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-2of3
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-3of3
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cb198230-af26-11f0-9dfc-4f433ff2c771-0

trigger 68 job(s) of type informing for the nightly release of OCP 4.21

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-agent-compact-fips
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-agent-ha-dualstack-conformance
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-agent-single-node-ipv6-conformance
  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-azure-aks-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.21-console-aws
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.21-periodics-e2e-aws
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-csi
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-cgroupsv2
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-fips
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-single-node-csi
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-single-node-serial
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-single-node-techpreview
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-single-node-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.21-upgrade-from-stable-4.20-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-upgrade-out-of-change
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-upi
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.21-periodics-e2e-azure
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-azure-csi
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade-out-of-change
  • periodic-ci-openshift-release-master-cnv-nightly-4.21-deploy-azure-kubevirt-ovn
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.21-periodics-e2e-gcp
  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-gcp-ovn-csi
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-gcp-ovn-rt
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-gcp-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-azure-kubevirt-ovn
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-dualstack
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-dualstack-techpreview
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6-techpreview
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-serial-ipv4
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-serial-virtualmedia-1of2
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-serial-virtualmedia-2of2
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-techpreview
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.21-upgrade-from-stable-4.20-e2e-metal-ipi-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-serial-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-serial-ovn-dualstack
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-upgrade-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.21-upgrade-from-stable-4.20-e2e-metal-ipi-upgrade-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.21-metal-ovn-single-node-recert-cluster-rename
  • periodic-ci-openshift-osde2e-main-nightly-4.21-osd-aws
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-osd-ccs-gcp
  • periodic-ci-openshift-osde2e-main-nightly-4.21-osd-gcp
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-proxy
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ovn-single-node-live-iso
  • periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.21-nightly-x86-payload-control-plane-6nodes
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-telco5g
  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-csi
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-serial
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-techpreview
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.21-e2e-vsphere-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-vsphere-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-upi
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-upi-serial
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cb198230-af26-11f0-9dfc-4f433ff2c771-1

trigger 5 job(s) of type blocking for the ci release of OCP 4.21

  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aks
  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cb198230-af26-11f0-9dfc-4f433ff2c771-2

@bertinatto
Copy link
Member Author

/retest

@bertinatto
Copy link
Member Author

/payload 4.21 nightly blocking
/payload 4.21 nightly informing

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2025

@bertinatto: trigger 13 job(s) of type blocking for the nightly release of OCP 4.21

  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-upgrade-fips
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-2of2
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-1of3
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-2of3
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-3of3
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/71cad030-af8a-11f0-9ebb-092d8b784d53-0

trigger 68 job(s) of type informing for the nightly release of OCP 4.21

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-agent-compact-fips
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-agent-ha-dualstack-conformance
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-agent-single-node-ipv6-conformance
  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-azure-aks-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.21-console-aws
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.21-periodics-e2e-aws
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-csi
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-cgroupsv2
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-fips
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-single-node-csi
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-single-node-serial
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-single-node-techpreview
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-single-node-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.21-upgrade-from-stable-4.20-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-upgrade-out-of-change
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-upi
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.21-periodics-e2e-azure
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-azure-csi
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade-out-of-change
  • periodic-ci-openshift-release-master-cnv-nightly-4.21-deploy-azure-kubevirt-ovn
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.21-periodics-e2e-gcp
  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-gcp-ovn-csi
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-gcp-ovn-rt
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-gcp-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-azure-kubevirt-ovn
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-dualstack
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-dualstack-techpreview
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6-techpreview
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-serial-ipv4
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-serial-virtualmedia-1of2
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-serial-virtualmedia-2of2
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-techpreview
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.21-upgrade-from-stable-4.20-e2e-metal-ipi-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-serial-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-serial-ovn-dualstack
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-upgrade-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.21-upgrade-from-stable-4.20-e2e-metal-ipi-upgrade-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.21-metal-ovn-single-node-recert-cluster-rename
  • periodic-ci-openshift-osde2e-main-nightly-4.21-osd-aws
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-osd-ccs-gcp
  • periodic-ci-openshift-osde2e-main-nightly-4.21-osd-gcp
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-proxy
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ovn-single-node-live-iso
  • periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.21-nightly-x86-payload-control-plane-6nodes
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-telco5g
  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-csi
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-serial
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-techpreview
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.21-e2e-vsphere-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-vsphere-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-upi
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-upi-serial
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/71cad030-af8a-11f0-9ebb-092d8b784d53-1

@bertinatto
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

@bertinatto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout baf6499 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-openstack-ovn baf6499 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node baf6499 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-serial baf6499 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade baf6499 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn baf6499 link false /test e2e-metal-ipi-ovn
ci/prow/okd-scos-e2e-aws-ovn 984334f link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt
Copy link

openshift-trt bot commented Oct 23, 2025

Job Failure Risk Analysis for sha: 984334f

Job Name Failure Risk
pull-ci-openshift-origin-main-okd-scos-e2e-aws-ovn IncompleteTests
Tests for this run (131) are below the historical average (3194): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 984334f

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-csi Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-csi Medium - "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-csi Medium - "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-csi Medium - "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" is a new test, and was only seen in one job.

New tests seen in this PR at sha: 984334f

  • "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "External Storage [Driver: pd.csi.storage.gke.io] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited and the pod is re-created on the same node after controller resize is finished" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "Import the release payload "nightly-arm64" from an external source" [Total: 3, Pass: 3, Fail: 0, Flake: 0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. e2e-images-update Related to images used by e2e tests jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants