CNTRLPLANE-1485:fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift #30307
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
wangke19
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance |
|
@wangke19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/61cb0080-9ad9-11f0-880c-01ec80b2888e-0 |
|
@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
wangke19
force-pushed
the
fix/hypershift-disruption-test
branch
from
5528069 to
9fb7603
Compare
|
@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@wangke19: This pull request references CNTRLPLANE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
wangke19
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/cc @LiangquanLi930 |
openshift-merge-robot
added
the
needs-rebase
…est on ARO and Baremetal Hypershift
wangke19
force-pushed
the
fix/hypershift-disruption-test
branch
from
ec330d3 to
10c5a6d
Compare
openshift-merge-robot
removed
the
needs-rebase
|
@wangke19: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test go-verify-deps |
openshift-ci-robot
added
the
verified
|
@wangke19: This PR has been marked as verified by |
|
/payload-job periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-azure-aks-ovn-conformance |
|
@wangke19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/04e7b330-afcf-11f0-9a50-00a773bc37ef-0 |
|
/test e2e-vsphere-ovn-upi |
|
/uncc @LiangquanLi930 |
|
/cc @bryan-cox |
|
/payload 4.21 nightly blocking |
|
@wangke19: trigger 13 job(s) of type blocking for the nightly release of OCP 4.21
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/14b2f1f0-afd2-11f0-91d3-d699c4cf2bec-0 |
|
From the following completed CI jobs, we can see that the monitor test |
|
/approve |
|
/cc @dgoodwin |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bryan-cox, wangke19 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
requested review from
smg247
and removed request for
dgoodwin
|
|
||
| adminRESTConfig *rest.Config | ||
| kubeClient kubernetes.Interface | ||
| isHypershift bool |
There was a problem hiding this comment.
Instead of 3 hypershift specific fields could a ControlPlaneType or HostedClusterType or some more generic field be added so that there is only one new field that might be reused in other cases as added.
5 participants
What does it do:
fix(disruption): Using correct internal LB of apiserver for monitor test on ARO and Baremetal Hypershift:
• Added new struct fields: isHypershift, isAROHCPCluster, isBareMetalHypershift
• Updated createInternalLBDeployment function to accept both apiIntHost and apiIntPort parameters
• Integrated the new logic for handling different cluster types (ARO HCP, bare metal HyperShift, standard)
• Added proper field assignments in the StartCollection function
Currently we don't have one MCE supported build for 4.21 main branch, so have to test related jobs on 4.19 and 4.20.
The related test
[Jira: "kube-apiserver"] can collect apiserver.openshift.io/disruption-actor=poller poller pod logs expand_moreinvloved code change has been passed on AWS test and ARO test with 4.20 PR fix #30310 and Baremetal with 4.19 PR fix #30383 (something wrong with baremetal install on 4.20)