Skip to content

[release-4.15] OCPBUGS-57335: Fix regex parser for censoring private key #29913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

[release-4.15] OCPBUGS-57335: Fix regex parser for censoring private key #29913

merged 1 commit into from
Sep 25, 2025

Conversation

@openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #29805

/assign KeerthanaAP

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 11, 2025
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-34163 has been cloned as Jira Issue OCPBUGS-57335. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-57335: Fix regex parser for censoring private key

In response to this:

This is an automated cherry-pick of #29805

/assign KeerthanaAP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-34163: Fix regex parser for censoring private key [release-4.15] OCPBUGS-57335: Fix regex parser for censoring private key Jun 11, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 11, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-57335, which is invalid:

  • expected dependent Jira Issue OCPBUGS-34163 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #29805

/assign KeerthanaAP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and sjenning June 11, 2025 12:56
@KeerthanaAP
Copy link

/retest

3 similar comments
@alokgoswami-ag
Copy link
Contributor

/retest

@alokgoswami-ag
Copy link
Contributor

/retest

@alokgoswami-ag
Copy link
Contributor

/retest

@alokgoswami-ag
Copy link
Contributor

/test e2e-metal-ipi-serial

@alokgoswami-ag
Copy link
Contributor

/test e2e-aws-ovn-single-node-upgrade

@alokgoswami-ag
Copy link
Contributor

/test e2e-gcp-fips-serial

@alokgoswami-ag
Copy link
Contributor

/test e2e-aws-ovn-single-node-serial

@alokgoswami-ag
Copy link
Contributor

/test e2e-aws-etcd-recovery

@alokgoswami-ag
Copy link
Contributor

/test e2e-gcp-disruptive

@alokgoswami-ag
Copy link
Contributor

/test e2e-metal-ipi-serial-ovn-ipv6

@alokgoswami-ag
Copy link
Contributor

/test e2e-vsphere-ovn-etcd-scaling

@alokgoswami-ag
Copy link
Contributor

/test e2e-gcp-fips-serial

@alokgoswami-ag
Copy link
Contributor

/test e2e-aws-ovn-single-node-upgrade

@alokgoswami-ag
Copy link
Contributor

/test e2e-aws-etcd-recovery

@alokgoswami-ag
Copy link
Contributor

/test e2e-aws-ovn-single-node-serial

@alokgoswami-ag
Copy link
Contributor

/retest

@tvardema
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2025
@alokgoswami-ag
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 19, 2025
@openshift-ci-robot
Copy link

@alokgoswami-ag: This pull request references Jira Issue OCPBUGS-57335, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-34163 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-34163 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 19, 2025
@sosiouxme
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sosiouxme, tvardema

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2025
@alokgoswami-ag
Copy link
Contributor

/verified later @alokgoswami-ag

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Sep 23, 2025
@openshift-ci-robot
Copy link

@alokgoswami-ag: This PR has been marked to be verified later by @alokgoswami-ag.

In response to this:

/verified later @alokgoswami-ag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD de84169 and 2 for PR HEAD b947c61 in total

@alokgoswami-ag
Copy link
Contributor

/test e2e-aws-ovn-fips

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2025 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-disruptive b947c61 link false /test e2e-gcp-disruptive
ci/prow/e2e-metal-ipi-serial b947c61 link false /test e2e-metal-ipi-serial
ci/prow/e2e-aws-ovn-single-node-upgrade b947c61 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial b947c61 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-disruptive b947c61 link false /test e2e-aws-disruptive
ci/prow/e2e-aws-etcd-recovery b947c61 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-gcp-fips-serial b947c61 link false /test e2e-gcp-fips-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@alokgoswami-ag
Copy link
Contributor

/test e2e-aws-ovn-fips

@openshift-merge-bot openshift-merge-bot bot merged commit c09e6f1 into openshift:release-4.15 Sep 25, 2025
35 of 42 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-57335: All pull requests linked via external trackers have merged:

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-57335 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #29805

/assign KeerthanaAP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@AnushaIH11
Copy link

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link
Author

@AnushaIH11: only openshift org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alokgoswami-ag
Copy link
Contributor

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link
Author

@alokgoswami-ag: #29913 failed to apply on top of branch "release-4.14":

Applying: Fix regex parser
Using index info to reconstruct a base tree...
M	test/extended/util/framework.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/util/framework.go
CONFLICT (content): Merge conflict in test/extended/util/framework.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix regex parser

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Shilpa-Gokul
Copy link
Contributor

release-4.14 branch PR- #30391

@AnushaIH11
Copy link

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link
Author

@AnushaIH11: #29913 failed to apply on top of branch "release-4.14":

Applying: Fix regex parser
Using index info to reconstruct a base tree...
M	test/extended/util/framework.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/util/framework.go
CONFLICT (content): Merge conflict in test/extended/util/framework.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix regex parser

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@KeerthanaAP KeerthanaAP

@tvardema tvardema

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @KeerthanaAP @alokgoswami-ag @tvardema @sosiouxme @AnushaIH11 @Shilpa-Gokul