-
Notifications
You must be signed in to change notification settings - Fork 448
WIP: TODO:Disable Swap mode #5294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ngopalak-redhat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
1 similar comment
/test all |
@ngopalak-redhat: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
33c1242
to
f8dc630
Compare
Fixes: https://issues.redhat.com/browse/OCPNODE-3747
Context:
With the release of 1.34 version of Kubernetes swap feature in Kubelet is GAed. This means that, customer can set FailSwapOn to false and SwapBehavior to LimitedSwap. OpenShift 4.21 is currently planned to adopt 1.34 version of Kubernetes. Hence users of OpenShift 4.21 and above are impacted by this upstream release of swap feature.
- What I did
- How to verify it
While this was tested the following PR was also required: openshift/api#2494
The cluster bot command was:
- Description for the changelog
Disables openshift users to use swap mode on the Kubelet