Skip to content

Conversation

ngopalak-redhat
Copy link

@ngopalak-redhat ngopalak-redhat commented Sep 22, 2025

Fixes: https://issues.redhat.com/browse/OCPNODE-3747
Context:
With the release of 1.34 version of Kubernetes swap feature in Kubelet is GAed. This means that, customer can set FailSwapOn to false and SwapBehavior to LimitedSwap. OpenShift 4.21 is currently planned to adopt 1.34 version of Kubernetes. Hence users of OpenShift 4.21 and above are impacted by this upstream release of swap feature.

- What I did

  1. Ensure that FailSwapOn and MemorySwap.SwapBehavior cannot be set by users of OpenShift
  2. Ensure that FailSwapOn is set to false on worker nodes and true on all other types of nodes. MemorySwap.SwapBehavior is always set to "NoSwap"

- How to verify it

  • Created a cluster in clusterBot with this PR and ensured that failSwapOn and swapBehavior is set
Worker Nodes:
  - All 3 worker nodes: failSwapOn: false, swapBehavior: "NoSwap"

  Control Plane Nodes:
  - All 3 master nodes: failSwapOn: true, swapBehavior: "NoSwap"

  The worker nodes have swap failure disabled (failSwapOn: false) while control plane nodes have it enabled (failSwapOn: true). All nodes have swapBehavior
  set to "NoSwap".

While this was tested the following PR was also required: openshift/api#2494

The cluster bot command was:

launch 4.21,openshift/machine-config-operator#5294,openshift/api#2494 gcp

- Description for the changelog

Disables openshift users to use swap mode on the Kubelet

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2025
Copy link
Contributor

openshift-ci bot commented Sep 22, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Sep 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ngopalak-redhat
Once this PR has been reviewed and has the lgtm label, please assign djoshy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ngopalak-redhat
Copy link
Author

/test all

1 similar comment
@ngopalak-redhat
Copy link
Author

/test all

Copy link
Contributor

openshift-ci bot commented Sep 23, 2025

@ngopalak-redhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 33c1242 link true /test e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-ovn 33c1242 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-op-single-node 33c1242 link true /test e2e-gcp-op-single-node
ci/prow/e2e-gcp-op-ocl 33c1242 link false /test e2e-gcp-op-ocl
ci/prow/e2e-aws-ovn-upgrade 33c1242 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-mco-disruptive 33c1242 link false /test e2e-gcp-mco-disruptive
ci/prow/e2e-gcp-op-2of2 33c1242 link true /test e2e-gcp-op-2of2
ci/prow/e2e-aws-ovn-windows 33c1242 link false /test e2e-aws-ovn-windows
ci/prow/e2e-aws-ovn-upgrade-out-of-change 33c1242 link false /test e2e-aws-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-1of2 33c1242 link true /test e2e-gcp-op-1of2
ci/prow/e2e-aws-mco-disruptive 33c1242 link false /test e2e-aws-mco-disruptive
ci/prow/e2e-agent-compact-ipv4 33c1242 link false /test e2e-agent-compact-ipv4
ci/prow/e2e-azure-ovn-upgrade-out-of-change 33c1242 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-hypershift 33c1242 link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant